Function listDevices has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.

Open

    public function listDevices()
    {
        $returnarray = [];
        $redirect = $this->getAttributes("device-specific:redirect"); // this might return per-device ones or the general one
        // if it was a general one, we are done. Find out if there is one such

• Read up
  Read up

File AbstractProfile.php has 459 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 

Method listDevices has 88 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function listDevices()
    {
        $returnarray = [];
        $redirect = $this->getAttributes("device-specific:redirect"); // this might return per-device ones or the general one
        // if it was a general one, we are done. Find out if there is one such

AbstractProfile has 26 functions (exceeds 20 allowed). Consider refactoring.

Open

abstract class AbstractProfile extends EntityWithDBProperties
{

    const HIDDEN = -1;
    const AVAILABLE = 0;

Function isEapTypeDefinitionComplete has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

    public function isEapTypeDefinitionComplete($eaptype)
    {
        if ($eaptype->needsServerCACert() && $eaptype->needsServerName()) {
            $missing = [];
            // silverbullet needs a support email address configured

• Read up
  Read up

Function significantChanges has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    public static function significantChanges($old, $new)
    {
        $retval = [];
        // check if a CA was added
        $x509 = new common\X509();

• Read up
  Read up

Function getCollapsedAttributes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

    public function getCollapsedAttributes($eap = [])
    {
        $collapsedList = [];
        foreach ($this->getAttributes() as $attribute) {
            // filter out eap-level attributes not pertaining to EAP type $eap

• Read up
  Read up

Method significantChanges has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function significantChanges($old, $new)
    {
        $retval = [];
        // check if a CA was added
        $x509 = new common\X509();

Method isEapTypeDefinitionComplete has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function isEapTypeDefinitionComplete($eaptype)
    {
        if ($eaptype->needsServerCACert() && $eaptype->needsServerName()) {
            $missing = [];
            // silverbullet needs a support email address configured

Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function __construct($profileIdRaw, $idpObject = NULL)
    {
        $this->databaseType = "INST";
        parent::__construct(); // we now have access to our INST database handle and logging
        $handle = DBConnection::handle("FRONTEND");

Function incrementDownloadStats has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    public function incrementDownloadStats($device, $area, $openRoaming)
    {
        if ($area == "admin" || $area == "user" || $area == "silverbullet") {
            $lang = $this->languageInstance->getLang();
            $this->frontendHandle->exec("INSERT INTO downloads (profile_id, device_id, lang, openroaming, downloads_$area) VALUES (? ,?, ?, ?, 1) ON DUPLICATE KEY UPDATE downloads_$area = downloads_$area + 1", "issi", $this->identifier, $device, $lang, $openRoaming);

• Read up
  Read up

Function readyForShowtime has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    private function readyForShowtime()
    {
        $properConfig = FALSE;
        $attribs = $this->getCollapsedAttributes();
        // do we have enough to go live? Check if any of the configured EAP methods is completely configured ...

• Read up
  Read up

Method saveDownloadDetails has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    protected function saveDownloadDetails($idpIdentifier, $profileId, $deviceId, $area, $lang, $eapType, $openRoaming)

Function getUserDownloadStats has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function getUserDownloadStats($device = NULL)
    {
        $columnName = "downloads_user";
        if ($this instanceof \core\ProfileSilverbullet) {
            $columnName = "downloads_silverbullet";

• Read up
  Read up

Method updateCache has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    abstract public function updateCache($device, $path, $mime, $integerEapType, $openRoaming);

Function testCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function testCache($device, $openRoaming)
    {
        $returnValue = ['cache' => NULL, 'mime' => NULL];
        $lang = $this->languageInstance->getLang();
        $result = $this->frontendHandle->exec("SELECT download_path, mime, UNIX_TIMESTAMP(installer_time) AS tm FROM downloads WHERE profile_id = ? AND device_id = ? AND lang = ? AND openroaming = ?", "issi", $this->identifier, $device, $lang, $openRoaming);

• Read up
  Read up

Avoid too many return statements within this method.

Open

        return TRUE;