Sign upLogin

GEANT/CAT

View on GitHub
Star
core/IdP.php

Summary

Maintainability
C
1 day
Test Coverage

File IdP.php has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
Severity: Minor
Found in core/IdP.php - About 3 hrs to fix

    Function getExternalDBSyncCandidates has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getExternalDBSyncCandidates($type)
    {
        $usedarray = [];
        $matchingCandidates = [];
        $syncstate = self::EXTERNAL_DB_SYNCSTATE_SYNCED;
    Severity: Minor
    Found in core/IdP.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function significantChanges has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function significantChanges($old, $new)
    {
        // check if the name of the inst was changed (in any language)
        $retval = [];
        $baseline = [];
    Severity: Minor
    Found in core/IdP.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(int $instId)
    {
        $this->databaseType = "INST";
        parent::__construct(); // now databaseHandle and logging is available
        $this->entityOptionTable = "institution_option";
    Severity: Minor
    Found in core/IdP.php - About 1 hr to fix

      Method getExternalDBSyncCandidates has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getExternalDBSyncCandidates($type)
    {
        $usedarray = [];
        $matchingCandidates = [];
        $syncstate = self::EXTERNAL_DB_SYNCSTATE_SYNCED;
      Severity: Minor
      Found in core/IdP.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status