Sign upLogin

GEANT/CAT

View on GitHub
Star
core/ProfileRADIUS.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method __construct has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($profileId, $idpObject = NULL)
    {
        parent::__construct($profileId, $idpObject);

        $this->entityOptionTable = "profile_option";
Severity: Minor
Found in core/ProfileRADIUS.php - About 1 hr to fix

    Method fetchDeviceOrEAPLevelAttributes has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function fetchDeviceOrEAPLevelAttributes($devicesOrEAPMethods)
    {
        // only one of the two is allowed to be set
        $temparray = [];
        $optioninstance = Options::instance();
    Severity: Minor
    Found in core/ProfileRADIUS.php - About 1 hr to fix

      Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct($profileId, $idpObject = NULL)
    {
        parent::__construct($profileId, $idpObject);

        $this->entityOptionTable = "profile_option";
      Severity: Minor
      Found in core/ProfileRADIUS.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateCache has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function updateCache($device, $path, $mime, $integerEapType, $openRoaming)
      Severity: Minor
      Found in core/ProfileRADIUS.php - About 35 mins to fix

        Method addAttributeAllLevels has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function addAttributeAllLevels($attrName, $attrLang, $attrValue, $eapType, $device)
        Severity: Minor
        Found in core/ProfileRADIUS.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status