Sign upLogin

GEANT/CAT

View on GitHub
Star
core/ProfileSilverbullet.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method __construct has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($profileId, $idpObject = NULL) {
        parent::__construct($profileId, $idpObject);

        $this->entityOptionTable = "profile_option";
        $this->entityIdColumn = "profile_id";
Severity: Major
Found in core/ProfileSilverbullet.php - About 2 hrs to fix

    Function getUserAuthRecords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getUserAuthRecords($userId, $testActivity = false) {
        // find out all certificate CNs belonging to the user, including expired and revoked ones
        $userData = $this->userStatus($userId);
        $certNames = [];
        foreach ($userData as $oneSlice) {
    Severity: Minor
    Found in core/ProfileSilverbullet.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getUserAuthRecords has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getUserAuthRecords($userId, $testActivity = false) {
        // find out all certificate CNs belonging to the user, including expired and revoked ones
        $userData = $this->userStatus($userId);
        $certNames = [];
        foreach ($userData as $oneSlice) {
    Severity: Minor
    Found in core/ProfileSilverbullet.php - About 1 hr to fix

      Method updateCache has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function updateCache($device, $path, $mime, $integerEapType, $openRoaming) {
      Severity: Minor
      Found in core/ProfileSilverbullet.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status