Sign upLogin

GEANT/CAT

View on GitHub
Star
core/common/OutsideComm.php

Summary

Maintainability
D
2 days
Test Coverage

Method adminInvitationMail has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function adminInvitationMail($targets, $introtext, $newtoken, $idpPrettyName, $federation, $type)
    {
        if (!in_array($introtext, OutsideComm::INVITE_CONTEXTS)) {
            throw new \Exception("Unknown invite mode!");
        }
Severity: Major
Found in core/common/OutsideComm.php - About 3 hrs to fix

    File OutsideComm.php has 305 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
    Severity: Minor
    Found in core/common/OutsideComm.php - About 3 hrs to fix

      Function mailAddressValidSecure has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function mailAddressValidSecure($address)
    {
        $loggerInstance = new \core\common\Logging();
        if (!filter_var($address, FILTER_VALIDATE_EMAIL)) {
            $loggerInstance->debug(4, "OutsideComm::mailAddressValidSecure: invalid mail address.");
      Severity: Minor
      Found in core/common/OutsideComm.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function adminInvitationMail has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function adminInvitationMail($targets, $introtext, $newtoken, $idpPrettyName, $federation, $type)
    {
        if (!in_array($introtext, OutsideComm::INVITE_CONTEXTS)) {
            throw new \Exception("Unknown invite mode!");
        }
      Severity: Minor
      Found in core/common/OutsideComm.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mailAddressValidSecure has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function mailAddressValidSecure($address)
    {
        $loggerInstance = new \core\common\Logging();
        if (!filter_var($address, FILTER_VALIDATE_EMAIL)) {
            $loggerInstance->debug(4, "OutsideComm::mailAddressValidSecure: invalid mail address.");
      Severity: Major
      Found in core/common/OutsideComm.php - About 2 hrs to fix

        Method sendSMS has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function sendSMS($number, $content)
    {
        $loggerInstance = new \core\common\Logging();
        switch (\config\ConfAssistant::SMSSETTINGS['provider']) {
            case 'Nexmo':
        Severity: Minor
        Found in core/common/OutsideComm.php - About 1 hr to fix

          Function sendSMS has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function sendSMS($number, $content)
    {
        $loggerInstance = new \core\common\Logging();
        switch (\config\ConfAssistant::SMSSETTINGS['provider']) {
            case 'Nexmo':
          Severity: Minor
          Found in core/common/OutsideComm.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method adminInvitationMail has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function adminInvitationMail($targets, $introtext, $newtoken, $idpPrettyName, $federation, $type)
          Severity: Minor
          Found in core/common/OutsideComm.php - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $retval;
            Severity: Major
            Found in core/common/OutsideComm.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (\config\Master::MAILSETTINGS['user'] === NULL && \config\Master::MAILSETTINGS['pass'] === NULL) {
            $mail->SMTPAuth = false;
        } else {
            $mail->SMTPAuth = true;
            $mail->Username = \config\Master::MAILSETTINGS['user'];
              Severity: Minor
              Found in core/common/OutsideComm.php and 1 other location - About 45 mins to fix
              core/SanityTests.php on lines 964..970

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status