Sign upLogin

GEANT/CAT

View on GitHub
Star
devices/ms/DeviceW8W10.php

Summary

Maintainability
C
1 day
Test Coverage

File DeviceW8W10.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
Severity: Minor
Found in devices/ms/DeviceW8W10.php - About 2 hrs to fix

    Function saveNetworkProfileSeparateHS has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        private function saveNetworkProfileSeparateHS($profileName, $network)
    {
        $out = '';
        if (!empty($network['ssid'])) {
            if ($this::separateSSIDprofiles === true && !empty($network['condition']) && $network['condition'] === 'locally_defined') {
    Severity: Minor
    Found in devices/ms/DeviceW8W10.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method writeInstaller has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function writeInstaller()
    {
        \core\common\Entity::intoThePotatoes();
        $this->prepareInstallerLang();
        $this->setupEapConfig();
    Severity: Minor
    Found in devices/ms/DeviceW8W10.php - About 1 hr to fix

      Function writeInstaller has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function writeInstaller()
    {
        \core\common\Entity::intoThePotatoes();
        $this->prepareInstallerLang();
        $this->setupEapConfig();
      Severity: Minor
      Found in devices/ms/DeviceW8W10.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method saveNetworkProfileSeparateHS has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function saveNetworkProfileSeparateHS($profileName, $network)
    {
        $out = '';
        if (!empty($network['ssid'])) {
            if ($this::separateSSIDprofiles === true && !empty($network['condition']) && $network['condition'] === 'locally_defined') {
      Severity: Minor
      Found in devices/ms/DeviceW8W10.php - About 1 hr to fix

        Method generateWlanProfile has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function generateWlanProfile($networkName, $ssids, $authentication, $encryption, $ois, $hs20 = false)
        Severity: Minor
        Found in devices/ms/DeviceW8W10.php - About 45 mins to fix

          Function writeMainNSH has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function writeMainNSH($eap, $attr)
    {
        $this->loggerInstance->debug(4, "writeMainNSH");
        $this->loggerInstance->debug(4, $attr);
        $this->loggerInstance->debug(4, "Device_id = ".$this->device_id."\n");
          Severity: Minor
          Found in devices/ms/DeviceW8W10.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status