Sign upLogin

GEANT/CAT

View on GitHub
Star

Showing 599 of 599 total issues

Function radius_restart has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def radius_restart():
    """Restart server via systemctl
    """
    start = time.time()
    sysbus = dbus.SystemBus()
Severity: Minor
Found in ansible/ManagedSP/templates/daemon/fr_restart.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function propertyCheckPolicy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function propertyCheckPolicy($cert)
    {
        $oids = [];
        if (isset($cert['extensions']['certificatePolicies']) &&  $cert['extensions']['certificatePolicies']) {
            foreach (\config\Diagnostics::RADIUSTESTS['TLS-acceptableOIDs'] as $key => $oid) {
Severity: Minor
Found in core/diag/RFC6614Tests.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function testCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function testCache($device, $openRoaming)
    {
        $returnValue = ['cache' => NULL, 'mime' => NULL];
        $lang = $this->languageInstance->getLang();
        $result = $this->frontendHandle->exec("SELECT download_path, mime, UNIX_TIMESTAMP(installer_time) AS tm FROM downloads WHERE profile_id = ? AND device_id = ? AND lang = ? AND openroaming = ?", "issi", $this->identifier, $device, $lang, $openRoaming);
Severity: Minor
Found in core/AbstractProfile.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    final public function __construct()
    {
        parent::__construct();
        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_PEAP_MSCHAP2, \core\common\EAP::EAPTYPE_TTLS_PAP, \core\common\EAP::EAPTYPE_TTLS_MSCHAP2, \core\common\EAP::EAPTYPE_TLS, \core\common\EAP::EAPTYPE_SILVERBULLET]);
        $this->specialities['media:openroaming'] = _("This device does not support provisioning of OpenRoaming.");
Severity: Minor
Found in devices/chromebook/DeviceChromebook.php and 2 other locations - About 30 mins to fix
devices/linux/DeviceLinux.php on lines 45..51
devices/linux/DeviceLinuxSh.php on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    final public function __construct() {
        parent::__construct();
        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_PEAP_MSCHAP2, \core\common\EAP::EAPTYPE_TTLS_PAP, \core\common\EAP::EAPTYPE_TTLS_MSCHAP2, \core\common\EAP::EAPTYPE_TLS, \core\common\EAP::EAPTYPE_SILVERBULLET]);
        $this->specialities['media:openroaming'] = _("This device does not support provisioning of OpenRoaming.");
        $this->specialities['media:consortium_OI'] = _("This device does not support provisioning of Passpoint networks.");
Severity: Minor
Found in devices/linux/DeviceLinux.php and 2 other locations - About 30 mins to fix
devices/chromebook/DeviceChromebook.php on lines 57..63
devices/linux/DeviceLinuxSh.php on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    final public function __construct() {
        parent::__construct();
        $this->setSupportedEapMethods([\core\common\EAP::EAPTYPE_PEAP_MSCHAP2, \core\common\EAP::EAPTYPE_TTLS_PAP, \core\common\EAP::EAPTYPE_TTLS_MSCHAP2, \core\common\EAP::EAPTYPE_TLS, \core\common\EAP::EAPTYPE_SILVERBULLET]);
        $this->specialities['media:openroaming'] = _("This device does not support provisioning of OpenRoaming.");
        $this->specialities['media:consortium_OI'] = _("This device does not support provisioning of Passpoint networks.");
Severity: Minor
Found in devices/linux/DeviceLinuxSh.php and 2 other locations - About 30 mins to fix
devices/chromebook/DeviceChromebook.php on lines 57..63
devices/linux/DeviceLinux.php on lines 45..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

                return ['result'=>FALSE, 'details'=>_("incorrect file type - must be UTF8 text")];
Severity: Major
Found in web/lib/admin/OptionParser.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return ['result'=>TRUE, 'details'=>''];
    Severity: Major
    Found in web/lib/admin/OptionParser.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return FALSE;
      Severity: Major
      Found in web/lib/admin/OptionParser.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return [$idp, $profile];
        Severity: Major
        Found in web/lib/admin/API.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return ['result'=>TRUE, ''];
          Severity: Major
          Found in web/lib/admin/OptionParser.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $content;
            Severity: Major
            Found in web/lib/admin/OptionParser.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return ['result'=>FALSE, 'details'=>''];
              Severity: Major
              Found in web/lib/admin/OptionParser.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return ['result'=>FALSE, 'details'=>''];
                Severity: Major
                Found in web/lib/admin/OptionParser.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return FALSE;
                  Severity: Major
                  Found in web/lib/admin/OptionParser.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return "";
                    Severity: Major
                    Found in devices/apple_mobileconfig/MobileconfigSuperclass.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return ['result'=>FALSE, 'details'=>''];
                      Severity: Major
                      Found in web/lib/admin/OptionParser.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return FALSE;
                        Severity: Major
                        Found in web/lib/admin/OptionParser.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return;
                          Severity: Major
                          Found in core/SanityTests.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return;
                            Severity: Major
                            Found in core/SanityTests.php - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language