Sign upLogin

GEANT/CAT

View on GitHub
Star
web/lib/admin/PageDecoration.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method productheader has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function productheader($area) {
        \core\common\Entity::intoThePotatoes();
        $language = $this->languageInstance->getLang();
        // this <div is closing in footer, keep it in PHP for Netbeans syntax
        // highlighting to work
Severity: Major
Found in web/lib/admin/PageDecoration.php - About 2 hrs to fix

    Function productheader has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function productheader($area) {
        \core\common\Entity::intoThePotatoes();
        $language = $this->languageInstance->getLang();
        // this <div is closing in footer, keep it in PHP for Netbeans syntax
        // highlighting to work
    Severity: Minor
    Found in web/lib/admin/PageDecoration.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method headerDiv has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function headerDiv($cap1, $language) {
        \core\common\Entity::intoThePotatoes();
        $place = parse_url($_SERVER['REQUEST_URI'], PHP_URL_PATH);

        $retval = "<div class='header'>
    Severity: Minor
    Found in web/lib/admin/PageDecoration.php - About 1 hr to fix

      Method footer has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function footer() {
        $cat = new \core\CAT();
        \core\common\Entity::intoThePotatoes();
        $retval = "</div><!-- thirdrow --></div><!-- trick -->
          </div><!-- pagecontent -->
      Severity: Minor
      Found in web/lib/admin/PageDecoration.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status