Method has too many lines. [12/10] Open
def search
image_search_results = execute_client_search
ensure_no_suggestion_when_results_present(image_search_results)
if image_search_results.total.zero? && image_search_results.suggestion.present?
suggestion = image_search_results.suggestion- Read upRead up
- Exclude checks
Checks if the length of a method exceeds some maximum value. Comment lines can optionally be allowed. The maximum allowed length is configurable.
You can set constructs you want to fold with CountAsOne.
Available are: 'array', 'hash', 'heredoc', and 'method_call'. Each construct
will be counted as one line regardless of its actual size.
NOTE: The ExcludedMethods and IgnoredMethods configuration is
deprecated and only kept for backwards compatibility.
Please use AllowedMethods and AllowedPatterns instead.
By default, there are no methods to allowed.
Example: CountAsOne: ['array', 'heredoc', 'method_call']
def m
array = [ # +1
1,
2
]
hash = { # +3
key: 'value'
}
<<~HEREDOC # +1
Heredoc
content.
HEREDOC
foo( # +1
1,
2
)
end # 6 pointsMethod search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def search
image_search_results = execute_client_search
ensure_no_suggestion_when_results_present(image_search_results)
if image_search_results.total.zero? && image_search_results.suggestion.present?
suggestion = image_search_results.suggestion- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"