Sign upLogin

GSA/code-gov-api

View on GitHub
Star

Showing 29 of 29 total issues

Function getApiRoutes has 176 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getApiRoutes(config, router) {

  const logger = new Logger({ name: 'routes.index', level: config.LOGGER_LEVEL });
  const adapter = new ElasticsearchAdapter({ hosts: config.ES_HOST, logger: Logger, mappings, settings });
Severity: Major
Found in routes/routes.js - About 7 hrs to fix

File utils.js has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const _ = require('lodash');
const fs = require('fs');
const git = require("git-rev");
const pkg = require("../package.json");
const Jsonfile = require("jsonfile");
Severity: Minor
Found in routes/utils.js - About 3 hrs to fix

Function getFlattenedMappingPropertiesByType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  static getFlattenedMappingPropertiesByType(mapping) {
    let props = {};

    const _recurseMappingTree = (mappingTree, pathArr) => {
      if (mappingTree["properties"]) {
Severity: Minor
Found in utils/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if(results.hasOwnProperty('data') === false || results.data.length === 0) {
        logger.warning(`No terms data was found for the query params: ${JSON.stringify(request.query)}`);
      }
Severity: Major
Found in routes/routes.js and 1 other location - About 1 hr to fix
routes/routes.js on lines 69..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if(results.hasOwnProperty('data') === false || results.data.length === 0) {
        logger.warning(`No repos data was found for the query params: ${JSON.stringify(request.query)}`);
      }
Severity: Major
Found in routes/routes.js and 1 other location - About 1 hr to fix
routes/routes.js on lines 96..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      } else if (mappingTree["type"]) {
        if (!props[mappingTree["type"]]) {
          props[mappingTree["type"]] = [];
        }
        props[mappingTree["type"]].push(pathArr.join("."));
Severity: Major
Found in utils/index.js and 1 other location - About 1 hr to fix
utils/index.js on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mappingTree["type"] == "nested") {
          if (!props[mappingTree["type"]]) {
            props[mappingTree["type"]] = [];
          }
          props[mappingTree["type"]].push(pathArr.join("."));
Severity: Major
Found in utils/index.js and 1 other location - About 1 hr to fix
utils/index.js on lines 21..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(config) {
    if(!config || !config.name) {
      config = {
        name: this.DEFAULT_LOGGER_NAME
      };
Severity: Minor
Found in utils/logger.js - About 1 hr to fix

Function omitPrivateKeys has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  static omitPrivateKeys(collection) {
    const omitFn = (value) => {
      if (value && typeof value === 'object') {
        Object.keys(value).forEach((key) => {
          if (key[0] === "_") {
Severity: Minor
Found in utils/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Rule doesn't have all its properties in alphabetical order.
Open

tr.failure {
Severity: Minor
Found in public/css/style.css by csslint

Values of 0 shouldn't have units specified.
Open

  border-spacing: 0px;
Severity: Minor
Found in public/css/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

th, td {
Severity: Minor
Found in public/css/style.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

tr.enhancement {
Severity: Minor
Found in public/css/style.css by csslint

Parsing error: Invalid ecmaVersion.
Open

const _ = require('lodash');
Severity: Minor
Found in routes/routes.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Invalid ecmaVersion.
Open

'use strict';
Severity: Minor
Found in newrelic.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Invalid ecmaVersion.
Open

const _ = require('lodash');
Severity: Minor
Found in routes/utils.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Rule doesn't have all its properties in alphabetical order.
Open

hr {
Severity: Minor
Found in public/css/style.css by csslint

Values of 0 shouldn't have units specified.
Open

  margin: 0px;
Severity: Minor
Found in public/css/style.css by csslint

Parsing error: Invalid ecmaVersion.
Open

const _ = require("lodash");
Severity: Minor
Found in utils/index.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Invalid ecmaVersion.
Open

const bunyan = require("bunyan");
Severity: Minor
Found in utils/logger.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language