Sign upLogin

GSI-HPC/sys-chef-cookbook

View on GitHub
Star
libraries/sys_harry.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method generate_harry_config has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_harry_config(sections, indent=1, flags={})
      if flags[:sections].nil?
        flags[:sections] = true
      end
Severity: Minor
Found in libraries/sys_harry.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_harry_config has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_harry_config(sections, indent=1, flags={})
      if flags[:sections].nil?
        flags[:sections] = true
      end
Severity: Minor
Found in libraries/sys_harry.rb - About 1 hr to fix

    Method render_harry_config has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def render_harry_config(config, key, value, indent, flags)
    Severity: Minor
    Found in libraries/sys_harry.rb - About 35 mins to fix

      Method render_harry_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def render_harry_config(config, key, value, indent, flags)
      indentation = ''
      indent.times { indentation << flags[:indentation] }
      case value
      when Array
      Severity: Minor
      Found in libraries/sys_harry.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status