Sign upLogin

GSI-HPC/sys-chef-cookbook

View on GitHub
Star
libraries/systemd_mount_provider.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method enable_fs has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def enable_fs
          if @current_resource.enabled && mount_options_unchanged?
            Chef::Log.debug("#{@new_resource} is already enabled - nothing to do")
            return nil
          end
Severity: Minor
Found in libraries/systemd_mount_provider.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enabled? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def enabled?
          unless @current_resource.enabled == true
            systemd_file = systemd_substitute(@new_resource.mount_point)
            if ::File.exist?("/etc/systemd/system/" + systemd_file)
              begin
Severity: Minor
Found in libraries/systemd_mount_provider.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method disable_fs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def disable_fs
          if @current_resource.enabled
            systemd_file = systemd_substitute(@new_resource.mount_point)
            if ::File.exist?("/etc/systemd/system/" + systemd_file)
              begin
Severity: Minor
Found in libraries/systemd_mount_provider.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status