Sign upLogin

GUSCRAWFORD/fpm

View on GitHub
Star

Showing 9 of 9 total issues

Function transformCommand has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function transformCommand(args, options, logger) {

    if (!args.directories) args.directories = [];
    if (args.directory) args.directories.push(args.directory);
    logger.info(options);
Severity: Minor
Found in src/transform-command.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function installCommand has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function installCommand(args, options, logger) {
    args.packagePaths.push(args.packagePath);
    args.packagePaths.forEach(packagePath=>copyPackage(packagePath));

    function copyPackage(packagePath:string) {
Severity: Major
Found in src/install-command.ts - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function captureVariants() {
    const REAL_TR = 'transform';
    let commandIndex = 2, command = process.argv[commandIndex];
    if (command === 'help') {
        commandIndex = 3;
    Severity: Major
    Found in src/transform-command.ts and 1 other location - About 3 hrs to fix
    src/install-command.ts on lines 8..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function captureVariants() {
    const REAL_ADD = 'add';
    let commandIndex = 2, command = process.argv[commandIndex];
    if (command === 'help') {
        commandIndex = 3;
    Severity: Major
    Found in src/install-command.ts and 1 other location - About 3 hrs to fix
    src/transform-command.ts on lines 7..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function transformCommand has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function transformCommand(args, options, logger) {

    if (!args.directories) args.directories = [];
    if (args.directory) args.directories.push(args.directory);
    logger.info(options);
    Severity: Major
    Found in src/transform-command.ts - About 2 hrs to fix

      Function createPackageJsonFor has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function createPackageJsonFor (projectPath) {
        var absPath = path.resolve(projectPath);
        logger.info(`ℹ️ Creating package.json for project in: ${absPath}`);
        fs.lstat(absPath,function lstat_cb (error, info) {
            //logger.info(info);
      Severity: Major
      Found in src/transform-command.ts - About 2 hrs to fix

        Function copy has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function copy(src:string, dest:string) {
        const absNodeModulesPath = path.join(process.cwd(), 'node_modules/');
        fs.lstat(src, (err,info)=>{
            if (err) {
                logger.error(`❌  Couldn't lstat ${src}:\n\t${err}`);
        Severity: Minor
        Found in src/install-command.ts - About 1 hr to fix

          Function copyPackage has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function copyPackage(packagePath:string) {
        const absPackagePath = path.join(process.cwd(),packagePath),
            absNodeModulesPath = path.join(process.cwd(),'node_modules');
        if (options.dry) logger.info(`ℹ️  Looking for package.json in ${absPackagePath}`);
        fs.readFile(
          Severity: Minor
          Found in src/install-command.ts - About 1 hr to fix

            Function transformKey has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function transformKey (error, packageData, pack, key) {
            switch(typeof (pack[key]) ) {
                case "object":
                    Object.keys(pack[key]).forEach(opr=>{
                        switch(opr) {
            Severity: Minor
            Found in src/transform-command.ts - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language