Garve/scikit-bonus

View on GitHub

Showing 7 of 12 total issues

Function add_time_features has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def add_time_features(
    df: pd.DataFrame,
    second: bool = False,
    minute: bool = False,
    hour: bool = False,
Severity: Minor
Found in skbonus/pandas/time_utils.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File _explainable_regressor.py has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import annotations

from typing import Any, Optional

import numpy as np
Severity: Minor
Found in skbonus/meta/_explainable_regressor.py - About 2 hrs to fix

    Function fit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def fit(
            self, X: np.ndarray, y: np.ndarray, sample_weight: np.ndarray = None
        ) -> ExplainableBoostingMetaRegressor:
            """
            Fit the model.
    Severity: Minor
    Found in skbonus/meta/_explainable_regressor.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_time_features has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def add_time_features(
    Severity: Major
    Found in skbonus/pandas/time_utils.py - About 1 hr to fix

      Function explode_date has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def explode_date(
      Severity: Minor
      Found in skbonus/pandas/time_utils.py - About 45 mins to fix

        Function fit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def fit(
                self,
                X: np.ndarray,
                y: np.ndarray,
                sample_weight: Optional[np.ndarray] = None,
        Severity: Minor
        Found in skbonus/linear_model/_scipy_regressors.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Minor
        Found in skbonus/meta/_explainable_regressor.py - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language