Sign upLogin

GeekPark/gpk_account

View on GitHub
Star
app/models/setting/edit_email_or_mobile.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method verify_code_correct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def verify_code_correct
    return false unless type
    key = "verify_code:#{type == 'email' ? email : mobile}"
    verify_code_eq = verify_code == Rails.cache.read(key)
    errors.add(:base, I18n.t('errors.invalid_verify_code')) unless verify_code_eq
Severity: Minor
Found in app/models/setting/edit_email_or_mobile.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

%w-literals should be delimited by [ and ]. (https://github.com/bbatsov/ruby-style-guide#percent-literal-braces)
Open

  validates :type, presence: { in: %w(email mobile) }
Severity: Minor
Found in app/models/setting/edit_email_or_mobile.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

There are no issues that match your filters.

Category
Status