GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Agenda/AppointmentFilterModel.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

File AppointmentFilterModel.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems
Severity: Minor
Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 2 hrs to fix

    Function loadFilterDependencies has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function loadFilterDependencies($activateDependencies = true)
        {
            if (! $this->filterOptions) {
                $maxLength = $this->get('gaf_calc_name', 'maxlength');
    
    
    Severity: Minor
    Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method applyDetailSettings has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function applyDetailSettings()
        {
            $this->loadFilterDependencies(true);
    
            $yesNo = $this->util->getTranslated()->getYesNo();
    Severity: Minor
    Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 1 hr to fix

      Method showTracks has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function showTracks($value)
          {
              if (! ($value && is_array($value))) {
                  return \MUtil_Html::create('em', $this->_('Not used in tracks'));
              }
      Severity: Minor
      Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 1 hr to fix

        Method applyBrowseSettings has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function applyBrowseSettings()
            {
                $this->loadFilterDependencies(false);
        
                $yesNo = $this->util->getTranslated()->getYesNo();
        Severity: Minor
        Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 1 hr to fix

          Function showTracks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function showTracks($value)
              {
                  if (! ($value && is_array($value))) {
                      return \MUtil_Html::create('em', $this->_('Not used in tracks'));
                  }
          Severity: Minor
          Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function showFilters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function showFilters($value)
              {
                  if (! ($value && is_array($value))) {
                      return \MUtil_Html::create('em', $this->_('Not used in filters'));
                  }
          Severity: Minor
          Found in classes/Gems/Agenda/AppointmentFilterModel.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid unused parameters such as '$name'.
          Open

              public function loadTracks($value, $isNew = false, $name = null, array $context = array())

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$value'.
          Open

              public function loadFilters($value, $isNew = false, $name = null, array $context = array())

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$value'.
          Open

              public function loadTracks($value, $isNew = false, $name = null, array $context = array())

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$name'.
          Open

              public function loadFilters($value, $isNew = false, $name = null, array $context = array())

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  $id           = intval($filterId);

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $li. Configured minimum length is 3.
          Open

                      $li = $list->li();

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $li. Configured minimum length is 3.
          Open

                      $li = $list->li();

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $db. Configured minimum length is 3.
          Open

              protected $db;

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          There are no issues that match your filters.

          Category
          Status