Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Agenda/AppointmentSelect.php

Summary

Maintainability
A
35 mins
Test Coverage
F
57%

The class AppointmentSelect has 14 public methods. Consider refactoring AppointmentSelect to keep number of public methods under 10.
Open

class AppointmentSelect extends \MUtil_Registry_TargetAbstract
{
    /**
     *
     * @var \Zend_Db_Select
Severity: Minor
Found in classes/Gems/Agenda/AppointmentSelect.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Function fromDate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function fromDate($from = null, $oper = '>=')
    {
        if ($from) {
            if ($from instanceof \Gems_Agenda_Appointment) {
                $from = $from->getAdmissionTime();
Severity: Minor
Found in classes/Gems/Agenda/AppointmentSelect.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    protected $db;
Severity: Minor
Found in classes/Gems/Agenda/AppointmentSelect.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status