GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Controller/Action/Helper/BatchRunner.php

Summary

Maintainability
A
3 hrs
Test Coverage
F
0%

Function direct has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function direct(\MUtil_Batch_BatchAbstract $batch, $title, $accessLog = null)
    {

        if ($batch->isConsole()) {
            $batch->runContinuous();
Severity: Minor
Found in classes/Gems/Controller/Action/Helper/BatchRunner.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method direct has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function direct(\MUtil_Batch_BatchAbstract $batch, $title, $accessLog = null)
    {

        if ($batch->isConsole()) {
            $batch->runContinuous();
Severity: Minor
Found in classes/Gems/Controller/Action/Helper/BatchRunner.php - About 1 hr to fix

    The method direct() contains an exit expression.
    Open

                exit;

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    The method direct() contains an exit expression.
    Open

                exit;

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
        public function bar($param)  {
            if ($param === 42) {
                exit(23);
            }
        }
    }

    Source https://phpmd.org/rules/design.html#exitexpression

    Avoid excessively long class names like Gems_Controller_Action_Helper_BatchRunner. Keep class name length under 40.
    Open

    class Gems_Controller_Action_Helper_BatchRunner extends \Zend_Controller_Action_Helper_Abstract
    {
        /**
         *
         * @param \MUtil_Batch_BatchAbstract $batch

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {
    
    }
    
    interface ATooLongInterfaceNameThatHintsAtADesignProblem {
    
    }

    Source https://phpmd.org/rules/naming.html#longclassname

    There are no issues that match your filters.

    Category
    Status