Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Controller/Action/Helper/SortableTable.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method ajaxAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function ajaxAction($table, $idField, $orderField)
    {
        $request = $this->getRequest();
        if ($request->isPost()) {
            $ids = $request->getPost('ids');
Severity: Minor
Found in classes/Gems/Controller/Action/Helper/SortableTable.php - About 1 hr to fix

    Function ajaxAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function ajaxAction($table, $idField, $orderField)
    {
        $request = $this->getRequest();
        if ($request->isPost()) {
            $ids = $request->getPost('ids');
    Severity: Minor
    Found in classes/Gems/Controller/Action/Helper/SortableTable.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid excessively long class names like Gems_Controller_Action_Helper_SortableTable. Keep class name length under 40.
    Open

    class Gems_Controller_Action_Helper_SortableTable extends \Zend_Controller_Action_Helper_Abstract
{
    /**
     * Handles sort in an ajax request
     *
    Severity: Minor
    Found in classes/Gems/Controller/Action/Helper/SortableTable.php by phpmd

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

    Source https://phpmd.org/rules/naming.html#longclassname

    Avoid variables with short names like $js. Configured minimum length is 3.
    Open

            $js = str_replace(array_keys($fields), $fields, $script);
    Severity: Minor
    Found in classes/Gems/Controller/Action/Helper/SortableTable.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

                $db = $this->getActionController()->db;
    Severity: Minor
    Found in classes/Gems/Controller/Action/Helper/SortableTable.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status