GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Default/AgendaDiagnosisAction.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Method createModel has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createModel($detailed, $action)
    {
        $translated = $this->util->getTranslated();
        $model      = new \MUtil_Model_TableModel('gems__agenda_diagnoses');

Severity: Minor
Found in classes/Gems/Default/AgendaDiagnosisAction.php - About 1 hr to fix

    Avoid unused parameters such as '$action'.
    Open

        protected function createModel($detailed, $action)

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$detailed'.
    Open

        protected function createModel($detailed, $action)

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    There are no issues that match your filters.

    Category
    Status