GemsTracker/gemstracker-library

Method createModel has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function createModel($detailed, $action)
    {
        $dblookup   = $this->util->getDbLookup();
        $translated = $this->util->getTranslated();
        $model      = new \MUtil_Model_TableModel('gems__agenda_staff');

Avoid unused parameters such as '$action'.

Open

    protected function createModel($detailed, $action)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$detailed'.

Open

    protected function createModel($detailed, $action)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

        $id = intval($this->_getIdParam());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}