classes/Gems/Default/CommTemplateAction.php
Method createModel has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function createModel($detailed, $action)
{
$allLanguages = $this->util->getLocalized()->getLanguages();
$currentLanguage = $this->locale->getLanguage();
$markEmptyCall = array($this->util->getTranslated(), 'markEmpty');Function createModel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public function createModel($detailed, $action)
{
$allLanguages = $this->util->getLocalized()->getLanguages();
$currentLanguage = $this->locale->getLanguage();
$markEmptyCall = array($this->util->getTranslated(), 'markEmpty');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function displayMultipleSubjects has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function displayMultipleSubjects($subValuesArray)
{
$html = \MUtil_Html::create()->div();
$output = '';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$language'. Open
Open
foreach($allLanguages as $code=>$language) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$output'. Open
Open
$output = '';- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid variables with short names like $em. Configured minimum length is 3. Open
Open
$em = \MUtil_Html::create('em');- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}