classes/Gems/Default/ContactAction.php
Method _getOrganizationsList
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function _getOrganizationsList()
{
$html = new \MUtil_Html_Sequence();
$sql = '
SELECT *
Method supportAction
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function supportAction()
{
$this->initHtml();
$this->html->h3($this->_('Support'));
Avoid variables with short names like $p. Configured minimum length is 3. Open
Open
$p = $html->pInfo(sprintf($this->_('%s is run by: '), $this->project->getName()));
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $li. Configured minimum length is 3. Open
Open
$li = $ul->li();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $ul. Configured minimum length is 3. Open
Open
$ul = $p->ul($data, array('class' => 'indent'));
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $ul. Configured minimum length is 3. Open
Open
$ul = $menuItem->toUl($this->getRequest());
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}