Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Default/GroupAction.php

Summary

Maintainability
B
5 hrs
Test Coverage
F
0%

Method createModel has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createModel($detailed, $action)
    {
        $dbLookup   = $this->util->getDbLookup();
        $rolesObj   = \Gems_Roles::getInstance();
        $userLoader = $this->loader->getUserLoader();
Severity: Major
Found in classes/Gems/Default/GroupAction.php - About 4 hrs to fix

    Function createModel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createModel($detailed, $action)
    {
        $dbLookup   = $this->util->getDbLookup();
        $rolesObj   = \Gems_Roles::getInstance();
        $userLoader = $this->loader->getUserLoader();
    Severity: Minor
    Found in classes/Gems/Default/GroupAction.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method createModel() has 128 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function createModel($detailed, $action)
    {
        $dbLookup   = $this->util->getDbLookup();
        $rolesObj   = \Gems_Roles::getInstance();
        $userLoader = $this->loader->getUserLoader();
    Severity: Minor
    Found in classes/Gems/Default/GroupAction.php by phpmd

    Avoid variables with short names like $br. Configured minimum length is 3.
    Open

            $br = \MUtil_Html::create('br');
    Severity: Minor
    Found in classes/Gems/Default/GroupAction.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status