GemsTracker/gemstracker-library

Method createModel has 54 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function createModel($detailed, $action)
    {
        $model = new \MUtil_Model_TableModel('gems__locations');
        $yesNo = $this->util->getTranslated()->getYesNo();

Avoid unused parameters such as '$detailed'.

Open

    protected function createModel($detailed, $action)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused parameters such as '$action'.

Open

    protected function createModel($detailed, $action)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid variables with short names like $sp. Configured minimum length is 3.

Open

        $sp = \MUtil_Html::raw(' ');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $tp. Configured minimum length is 3.

Open

        $tp = new \MUtil_Model_Type_ConcatenatedRow(':', ', ');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $br. Configured minimum length is 3.

Open

        $br = \MUtil_Html::create('br');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}