Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Default/OrganizationAction.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
12%

Function changeUiAction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function changeUiAction()
    {
        $request  = $this->getRequest();
        $orgId    = urldecode($request->getParam('org'));
        $oldOrg   = $this->currentUser->getCurrentOrganizationId();
Severity: Minor
Found in classes/Gems/Default/OrganizationAction.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkOrgAction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function checkOrgAction()
    {
        $go    = true;
        $orgId = $this->_getIdParam();
        $org   = $this->loader->getOrganization($orgId);
Severity: Minor
Found in classes/Gems/Default/OrganizationAction.php - About 1 hr to fix

    Method changeUiAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function changeUiAction()
    {
        $request  = $this->getRequest();
        $orgId    = urldecode($request->getParam('org'));
        $oldOrg   = $this->currentUser->getCurrentOrganizationId();
    Severity: Minor
    Found in classes/Gems/Default/OrganizationAction.php - About 1 hr to fix

      Method getSearchFilter has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getSearchFilter($useRequest = true)
    {
        $filter = parent::getSearchFilter();

        if (isset($filter['respondentstatus'])) {
      Severity: Minor
      Found in classes/Gems/Default/OrganizationAction.php - About 1 hr to fix

        Function createModel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createModel($detailed, $action)
    {
        if ($this->escort instanceof \Gems_Project_Layout_MultiLayoutInterface) {
            $styles = \MUtil_Lazy::call(array($this->escort, 'getStyles'));
        } else {
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkOrgAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function checkOrgAction()
    {
        $go    = true;
        $orgId = $this->_getIdParam();
        $org   = $this->loader->getOrganization($orgId);
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSearchFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSearchFilter($useRequest = true)
    {
        $filter = parent::getSearchFilter();

        if (isset($filter['respondentstatus'])) {
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid unused parameters such as '$useRequest'.
        Open

            public function getSearchFilter($useRequest = true)
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid variables with short names like $db. Configured minimum length is 3.
        Open

            public $db;
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $go. Configured minimum length is 3.
        Open

                $go    = true;
        Severity: Minor
        Found in classes/Gems/Default/OrganizationAction.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        There are no issues that match your filters.

        Category
        Status