GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Default/PrivilegesAction.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Function setNonExistent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Wontfix

    protected function setNonExistent($nonexistent)
    {
        if ($nonexistent) {
            $translatedNonexistent = [];
            foreach($nonexistent as $right=>$values) {
Severity: Minor
Found in classes/Gems/Default/PrivilegesAction.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getPrivileges has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    protected function getPrivileges()
    {
        if (!$this->privileges) {
            $privileges = [];

Severity: Minor
Found in classes/Gems/Default/PrivilegesAction.php - About 1 hr to fix

    Avoid unused local variables such as '$description'.
    Wontfix

                foreach ($unassigned as $privilege => $description) {

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused parameters such as '$detailed'.
    Wontfix

        protected function createModel($detailed, $action)

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$action'.
    Wontfix

        protected function createModel($detailed, $action)

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid excessively long variable names like $translatedNonexistent. Keep variable name length under 20.
    Wontfix

                $translatedNonexistent = [];

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status