Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Default/RespondentChildActionAbstract.php

Summary

Maintainability
A
35 mins
Test Coverage
D
61%

Function getRespondent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRespondent()
    {
        if (! $this->_respondent) {
            $patientNumber  = $this->_getParam(\MUtil_Model::REQUEST_ID1);
            $organizationId = $this->_getParam(\MUtil_Model::REQUEST_ID2);
Severity: Minor
Found in classes/Gems/Default/RespondentChildActionAbstract.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long class names like Gems_Default_RespondentChildActionAbstract. Keep class name length under 40.
Open

abstract class Gems_Default_RespondentChildActionAbstract extends \Gems_Controller_ModelSnippetActionAbstract
{
    /**
     *
     * @var \Gems_Tracker_Respondent
Severity: Minor
Found in classes/Gems/Default/RespondentChildActionAbstract.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

There are no issues that match your filters.

Category
Status