GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Default/RoleAction.php

Summary

Maintainability
B
6 hrs
Test Coverage
F
0%

Function formatLongLine has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function formatLongLine(array $privileges)
    {
        $output     = \MUtil_Html::create('div');

        if (count($privileges)) {
Severity: Minor
Found in classes/Gems/Default/RoleAction.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createModel has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createModel($detailed, $action)
    {
        $model = new \MUtil_Model_TableModel('gems__roles');

        $model->set('grl_name', 'label', $this->_('Name'),
Severity: Minor
Found in classes/Gems/Default/RoleAction.php - About 1 hr to fix

    Function formatPrivileges has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function formatPrivileges(array $privileges)
        {
            if (count($privileges)) {
                $output     = \MUtil_Html_ListElement::ul();
                $privileges = array_combine($privileges, $privileges);
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$description'.
    Open

            foreach ($unassigned as $privilege => $description) {
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function getInheritedPrivileges(array $parents)
        {
            if (! $parents) {
                return array();
            }
    Severity: Major
    Found in classes/Gems/Default/RoleAction.php and 1 other location - About 2 hrs to fix
    classes/Gems/Snippets/Role/RoleEditFormSnippet.php on lines 202..221

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    The variable $privileges_string is not named in camelCase.
    Open

        public function formatNotAllowed($data)
        {
            list($parents_string, $privileges_string) = explode("\t", $data, 2);
            $parents    = explode(',', $parents_string);
            $privileges = explode(',', $privileges_string);
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $all_existing is not named in camelCase.
    Open

        public function privilegeAction()
        {
            $privileges = array();
    
            foreach ($this->acl->getPrivilegeRoles() as $privilege => $roles) {
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $parents_string is not named in camelCase.
    Open

        public function formatNotAllowed($data)
        {
            list($parents_string, $privileges_string) = explode("\t", $data, 2);
            $parents    = explode(',', $parents_string);
            $privileges = explode(',', $privileges_string);
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $all_existing is not named in camelCase.
    Open

        public function privilegeAction()
        {
            $privileges = array();
    
            foreach ($this->acl->getPrivilegeRoles() as $privilege => $roles) {
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $privileges_string is not named in camelCase.
    Open

        public function formatNotAllowed($data)
        {
            list($parents_string, $privileges_string) = explode("\t", $data, 2);
            $parents    = explode(',', $parents_string);
            $privileges = explode(',', $privileges_string);
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $parents_string is not named in camelCase.
    Open

        public function formatNotAllowed($data)
        {
            list($parents_string, $privileges_string) = explode("\t", $data, 2);
            $parents    = explode(',', $parents_string);
            $privileges = explode(',', $privileges_string);
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $all_existing is not named in camelCase.
    Open

        public function privilegeAction()
        {
            $privileges = array();
    
            foreach ($this->acl->getPrivilegeRoles() as $privilege => $roles) {
    Severity: Minor
    Found in classes/Gems/Default/RoleAction.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status