classes/Gems/Default/SourceAction.php
Method createModel
has 83 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function createModel($detailed, $action)
{
$tracker = $this->loader->getTracker();
$model = new \MUtil_Model_TableModel('gems__sources');
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
public $db;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}