The class BeforeAnsweringAbstract has an overall complexity of 50 which is very high. The configured complexity threshold is 50. Open
abstract class BeforeAnsweringAbstract extends \MUtil_Translate_TranslateableAbstract
implements \Gems_Event_SurveyBeforeAnsweringEventInterface
{
/**
* @var FIELDNAME in ucase => fieldname- Exclude checks
Function getPreviousTokenByCode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getPreviousTokenByCode(\Gems_Tracker_Token $token)
{
$code = $token->getSurvey()->getCode();
$prev = $token;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkOutputKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function checkOutputKey($key, $keepAnswer = true, $value = null, $log = false)
{
$ukey = $this->mapKeysCaseSensitive ? $key : strtoupper($key);
if (! isset($this->_answerKeyMap[$ukey])) {
if ($log) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getTrackFieldValues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getTrackFieldValues(\Gems_Tracker_RespondentTrack $respondentTrack)
{
$fieldCode2Label = $respondentTrack->getCodeFields();
$rawFieldData = $respondentTrack->getFieldData(); // Date (time) fields are unprocessed here
$results = [];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$label'. Open
foreach ($fieldCode2Label as $key => $label) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}