Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Event/Survey/BeforeAnswering/GetPreviousAnswersByCode.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Function processTokenInsertion has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function processTokenInsertion(\Gems_Tracker_Token $token)
    {
        if ($token->getReceptionCode()->isSuccess() && (! $token->isCompleted())) {
            // Preparation for a more general object class
            $code = $token->getSurvey()->getCode();
Severity: Minor
Found in classes/Gems/Event/Survey/BeforeAnswering/GetPreviousAnswersByCode.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long class names like Gems_Event_Survey_BeforeAnswering_GetPreviousAnswersByCode. Keep class name length under 40.
Open

class Gems_Event_Survey_BeforeAnswering_GetPreviousAnswersByCode extends \MUtil_Registry_TargetAbstract
    implements \Gems_Event_SurveyBeforeAnsweringEventInterface
{
    /**
     * Set as this is a \MUtil_Registry_TargetInterface
Severity: Minor
Found in classes/Gems/Event/Survey/BeforeAnswering/GetPreviousAnswersByCode.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

There are no issues that match your filters.

Category
Status