GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Event/Survey/Display/OnlyAnsweredWithCharts.php

Summary

Maintainability
A
50 mins
Test Coverage
F
25%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 *
 * @package    Gems
 * @subpackage Events
Severity: Minor
Found in classes/Gems/Event/Survey/Display/OnlyAnsweredWithCharts.php and 1 other location - About 50 mins to fix
classes/Gems/Event/Survey/Display/AllOfSurveyWithCharts.php on lines 1..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 97.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long class names like Gems_Event_Survey_Display_OnlyAnsweredWithCharts. Keep class name length under 40.
Open

class Gems_Event_Survey_Display_OnlyAnsweredWithCharts extends \Gems_Event_Survey_Display_OnlyAnswered
{
    /**
     * Function that returns the snippets to use for this display.
     *

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

There are no issues that match your filters.

Category
Status