GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Export/StreamingExcelExport.php

Summary

Maintainability
D
2 days
Test Coverage
D
60%

Function finalizeFiles has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function finalizeFiles($data=null)
    {
        if ($this->combineFilesEnabled($data)) {
            $files = $this->getFiles();

Severity: Minor
Found in classes/Gems/Export/StreamingExcelExport.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addRows has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public function addRows($data, $modelId, $tempFilename, $filter)
    {
        $this->data = $data;
        $this->modelId = $modelId;
        $this->model = $this->getModel();
Severity: Minor
Found in classes/Gems/Export/StreamingExcelExport.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File StreamingExcelExport.php has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Pulse
Severity: Minor
Found in classes/Gems/Export/StreamingExcelExport.php - About 3 hrs to fix

    The class StreamingExcelExport has an overall complexity of 66 which is very high. The configured complexity threshold is 50.
    Open

    class StreamingExcelExport extends ExportAbstract
    {
        /**
         * @var string  Current used file extension
         */

    Function addFooter has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function addFooter($filename, $modelId = null, $data = null)
        {
            parent::addFooter($filename, $modelId, $data);
            
            $this->model = $this->getModel();
    Severity: Minor
    Found in classes/Gems/Export/StreamingExcelExport.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addRows has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function addRows($data, $modelId, $tempFilename, $filter)
        {
            $this->data = $data;
            $this->modelId = $modelId;
            $this->model = $this->getModel();
    Severity: Minor
    Found in classes/Gems/Export/StreamingExcelExport.php - About 2 hrs to fix

      Method addFooter has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function addFooter($filename, $modelId = null, $data = null)
          {
              parent::addFooter($filename, $modelId, $data);
              
              $this->model = $this->getModel();
      Severity: Minor
      Found in classes/Gems/Export/StreamingExcelExport.php - About 1 hr to fix

        Method finalizeFiles has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function finalizeFiles($data=null)
            {
                if ($this->combineFilesEnabled($data)) {
                    $files = $this->getFiles();
        
        
        Severity: Minor
        Found in classes/Gems/Export/StreamingExcelExport.php - About 1 hr to fix

          Function preprocessModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function preprocessModel()
              {
                  parent::preprocessModel();
          
                  $labeledCols = $this->getLabeledColumns();
          Severity: Minor
          Found in classes/Gems/Export/StreamingExcelExport.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method addRows() has an NPath complexity of 514. The configured NPath complexity threshold is 200.
          Open

              public function addRows($data, $modelId, $tempFilename, $filter)
              {
                  $this->data = $data;
                  $this->modelId = $modelId;
                  $this->model = $this->getModel();

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method addRows() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

              public function addRows($data, $modelId, $tempFilename, $filter)
              {
                  $this->data = $data;
                  $this->modelId = $modelId;
                  $this->model = $this->getModel();

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid unused parameters such as '$data'.
          Open

              public function getFormElements(&$form, &$data)

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$row'.
          Open

              public function addRow($row, $file)

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$data'.
          Open

              protected function getWriter($filename, $data)

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$rowNumber'.
          Open

              public function addRowWithCount($row, $writer, $rowNumber)

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$file'.
          Open

              public function addRow($row, $file)

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          There are no issues that match your filters.

          Category
          Status