File MenuAbstract.php has 628 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 *
 * @package    Gems

Gems_Menu_MenuAbstract has 37 functions (exceeds 20 allowed). Consider refactoring.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

Method addTrackBuilderMenu has 94 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function addTrackBuilderMenu($label, array $other = array())
    {
        $setup = $this->addContainer($label);

        // SURVEY SOURCES CONTROLLER

The class Gems_Menu_MenuAbstract has 23 public methods. Consider refactoring Gems_Menu_MenuAbstract to keep number of public methods under 10.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class Gems_Menu_MenuAbstract has an overall complexity of 85 which is very high. The configured complexity threshold is 50.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

• Exclude checks
  • Disable engine
  • Disable check

The class Gems_Menu_MenuAbstract has 31 non-getter- and setter-methods. Consider refactoring Gems_Menu_MenuAbstract to keep number of methods under 25.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Function _toNavigationArray has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

    protected function _toNavigationArray(\Gems_Menu_ParameterCollector $source)
    {
        $this->sortByOrder();
        $lastParams = null;
        $pageIdx    = 0;

• Read up
  Read up

Function _addUsedPrivileges has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up

Method addProjectInfoPage has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function addProjectInfoPage($label)
    {
        $page = $this->addPage($label, 'pr.project-information', 'project-information');
        $page->addAction($this->_('Errors'),     null, 'errors');
        $page->addAction($this->_('PHP'),        null, 'php');

Method addStaffPage has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function addStaffPage($label, array $other = array())
    {
        if ($this->currentUser->hasPrivilege('pr.staff.edit.all')) {
            $filter = array_keys($this->loader->getUtil()->getDbLookup()->getOrganizations());
        } else {

Method _toNavigationArray has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function _toNavigationArray(\Gems_Menu_ParameterCollector $source)
    {
        $this->sortByOrder();
        $lastParams = null;
        $pageIdx    = 0;

Function applyAcl has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    protected function applyAcl(\MUtil_Acl $acl, $userRole)
    {
        foreach ($this->_subItems as $item) {

            $allowed = $item->get('allowed', true);

• Read up
  Read up

Method addButtonOnly has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function addButtonOnly($label, $privilege, $controller, $action = 'index', array $other = array())

Method addPage has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function addPage($label, $privilege, $controller, $action = 'index', array $other = array())

Function setBranchVisible has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    protected function setBranchVisible(array $activeBranch)
    {
        $current = array_pop($activeBranch);

        foreach ($this->_subItems as $item) {

• Read up
  Read up

The method addTrackBuilderMenu() has 126 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function addTrackBuilderMenu($label, array $other = array())
    {
        $setup = $this->addContainer($label);

        // SURVEY SOURCES CONTROLLER

• Exclude checks
  • Disable engine
  • Disable check

The class Gems_Menu_MenuAbstract has 1095 lines of code. Current threshold is 1000. Avoid really long classes.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

• Exclude checks
  • Disable engine
  • Disable check

The method _toNavigationArray() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    protected function _toNavigationArray(\Gems_Menu_ParameterCollector $source)
    {
        $this->sortByOrder();
        $lastParams = null;
        $pageIdx    = 0;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class Gems_Menu_MenuAbstract has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.

Open

abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid unused local variables such as '$ajaxPage'.

Open

        $ajaxPage = $this->addPage($this->_('Round Selection'), 'pr.comm.job', 'comm-job', 'roundselect', array('visible' => false));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$codePage'.

Open

        $codePage = $showPage->addPage($this->_('Export codebook'), 'pr.survey-maintenance.code-book-export', 'survey-code-book-export', 'export')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$page'.

Open

        $page = $import->addPage($this->_('Answers'), 'pr.survey-maintenance.answer-import', 'file-import', 'answers-import');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused parameters such as '$other'.

Open

    public function addTrackBuilderMenu($label, array $other = array())

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Avoid unused local variables such as '$createPage'.

Open

        $createPage = $page->addCreateAction();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$createPage'.

Open

        $createPage = $page->addCreateAction();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$ajaxPage'.

Open

        $ajaxPage = $this->addPage($this->_('Sort rounds'), 'pr.track-maintenance.edit', 'track-rounds', 'sort', array('visible' => false));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid variables with short names like $a. Configured minimum length is 3.

Open

        $a = $aItem->get('order');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $b. Configured minimum length is 3.

Open

        $b = $bItem->get('order');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_itemlabel is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_itemlabel is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_itemlabel is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_privilege is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $_itemlabel is not named in camelCase.

Open

    protected function _addUsedPrivileges(array &$privileges, $label)
    {
        foreach ($this->_subItems as $item) {
            // Skip autofilter action, but include all others
            if ($item->get('action') == 'autofilter') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}