Method applyEditSettings has 115 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function applyEditSettings()
    {
        $this->notEditing = false;

        $this->applyDetailSettings();

Method applyBrowseSettings has 101 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function applyBrowseSettings()
    {
        $dbLookup    = $this->util->getDbLookup();
        $definitions = $this->loader->getUserLoader()->getAvailableStaffDefinitions();
        $localized   = $this->util->getLocalized();

File OrganizationModel.php has 292 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 * The organization model
 *

Function processAfterLoad has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function processAfterLoad($data, $new = false, $isPostData = false)
    {
        $data = parent::processAfterLoad($data, $new, $isPostData);

        if ($data instanceof \Traversable) {

• Read up
  Read up

Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function save(array $newValues, array $filter = null, array $saveTables = null)
    {
        //First perform a save
        $savedValues = parent::save($newValues, $filter, $saveTables);

• Read up
  Read up

Function applyBrowseSettings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function applyBrowseSettings()
    {
        $dbLookup    = $this->util->getDbLookup();
        $definitions = $this->loader->getUserLoader()->getAvailableStaffDefinitions();
        $localized   = $this->util->getLocalized();

• Read up
  Read up

The method applyBrowseSettings() has 126 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function applyBrowseSettings()
    {
        $dbLookup    = $this->util->getDbLookup();
        $definitions = $this->loader->getUserLoader()->getAvailableStaffDefinitions();
        $localized   = $this->util->getLocalized();

• Exclude checks
  • Disable engine
  • Disable check

The method applyEditSettings() has 141 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function applyEditSettings()
    {
        $this->notEditing = false;

        $this->applyDetailSettings();

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

            //     @@TODO: See if we can enable it when these methods are changed into a dependency

• Exclude checks
  • Disable engine
  • Disable check

Avoid variables with short names like $tp. Configured minimum length is 3.

Open

        $tp = new \MUtil_Model_Type_ConcatenatedRow(':', ', ');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}