GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Model/Transform/TranslateFieldEditor.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function transformLoadSubModel has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    protected function transformLoadSubModel(
        \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$data, array $join,
        $name, $new, $isPostData)
    {
        $allLanguages = $this->getLocales();
Severity: Minor
Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFieldInfo has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFieldInfo(\MUtil_Model_ModelAbstract $model)
    {
        $items = $model->getColNames('translate');

        foreach($items as $itemName) {
Severity: Major
Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 3 hrs to fix

    Method transformLoadSubModel has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function transformLoadSubModel(
            \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$data, array $join,
            $name, $new, $isPostData)
        {
            $allLanguages = $this->getLocales();
    Severity: Minor
    Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 1 hr to fix

      Function getFieldInfo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFieldInfo(\MUtil_Model_ModelAbstract $model)
          {
              $items = $model->getColNames('translate');
      
              foreach($items as $itemName) {
      Severity: Minor
      Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transformLoadSubModel has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$data, array $join,
              $name, $new, $isPostData)
      Severity: Major
      Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 50 mins to fix

        Method transformSaveSubModel has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$row, array $join, $name)
        Severity: Minor
        Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 35 mins to fix

          Function transformSaveSubModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function transformSaveSubModel(
                  \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$row, array $join, $name)
              {
                  if (!isset($row['table_keys'])) {
                      $tableKeys = $model->getKeys();
          Severity: Minor
          Found in classes/Gems/Model/Transform/TranslateFieldEditor.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method getFieldInfo() has 108 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

              public function getFieldInfo(\MUtil_Model_ModelAbstract $model)
              {
                  $items = $model->getColNames('translate');
          
                  foreach($items as $itemName) {

          The method transformLoadSubModel() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              protected function transformLoadSubModel(
                  \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$data, array $join,
                  $name, $new, $isPostData)
              {
                  $allLanguages = $this->getLocales();

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid unused local variables such as '$keyName'.
          Open

                      foreach($tableKeys as $keyName => $column) {

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused parameters such as '$value'.
          Open

                      $emptyValue = function($value) { echo ''; };

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$join'.
          Open

                  \MUtil_Model_ModelAbstract $model, \MUtil_Model_ModelAbstract $sub, array &$data, array $join,

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
          {
              private function bar($howdy)
              {
                  // $howdy is not used
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused local variables such as '$languageName'.
          Open

                      foreach($allLanguages as $isoLang=>$languageName) {

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid unused local variables such as '$keyName'.
          Open

                      foreach($tableKeys as $keyName => $column) {

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          Avoid excessively long variable names like $copyParentFieldSettings. Keep variable name length under 20.
          Open

              protected $copyParentFieldSettings = [
                  'elementClass',
                  'maxlength',
                  'minlength',
                  'size',

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
              protected $reallyLongIntName = -3; // VIOLATION - Field
              public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                  $otherReallyLongName = -5; // VIOLATION - Local
                  for ($interestingIntIndex = 0; // VIOLATION - For
                       $interestingIntIndex < 10;
                       $interestingIntIndex++ ) {
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#longvariable

          There are no issues that match your filters.

          Category
          Status