Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Model/Translator/RespondentAnswerTranslator.php

Summary

Maintainability
C
1 day
Test Coverage
F
36%

Function getNoTokenError has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function getNoTokenError(array $row, $key)
    {
        $messages = array();
        if (! (isset($row[$this->patientNrField]) && $row[$this->patientNrField])) {
            $messages[] = sprintf($this->_('Missing respondent number in %s field.'), $this->patientNrField);
Severity: Minor
Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getNoTokenError has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getNoTokenError(array $row, $key)
    {
        $messages = array();
        if (! (isset($row[$this->patientNrField]) && $row[$this->patientNrField])) {
            $messages[] = sprintf($this->_('Missing respondent number in %s field.'), $this->patientNrField);
Severity: Major
Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 3 hrs to fix

    Method findTokenFor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function findTokenFor(array $row)
    {
        if (! (isset($row[$this->patientNrField], $row[$this->orgIdField]) &&
                $row[$this->patientNrField] &&
                $row[$this->orgIdField] &&
    Severity: Minor
    Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 1 hr to fix

      Method findRespondentTrackFor has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function findRespondentTrackFor(array $row)
    {
        if (! (isset($row[$this->patientNrField], $row[$this->orgIdField]) &&
                $row[$this->patientNrField] &&
                $row[$this->orgIdField])) {
      Severity: Minor
      Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                            return sprintf(
                            $this->_('Respondent %s has only deleted %s surveys.'),
                            $respondent->getPatientNumber(),
                            $survey->getName()
                            );
        Severity: Major
        Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return parent::getNoTokenError($row, $key);
          Severity: Major
          Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return sprintf(
                            $this->_('Respondent %s does not have a valid %s track.'),
                            $respondent->getPatientNumber(),
                            $trackEngine->getTrackName()
                            );
            Severity: Major
            Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return sprintf(
                        $this->_('Respondent %s has no %s surveys.'),
                        $respondent->getPatientNumber(),
                        $survey->getName()
                        );
              Severity: Major
              Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php - About 30 mins to fix

                The method getNoTokenError() has an NPath complexity of 2196. The configured NPath complexity threshold is 200.
                Open

                    public function getNoTokenError(array $row, $key)
    {
        $messages = array();
        if (! (isset($row[$this->patientNrField]) && $row[$this->patientNrField])) {
            $messages[] = sprintf($this->_('Missing respondent number in %s field.'), $this->patientNrField);
                Severity: Minor
                Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
    function bar() {
        // lots of complicated code
    }
}

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method getNoTokenError() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                Open

                    public function getNoTokenError(array $row, $key)
    {
        $messages = array();
        if (! (isset($row[$this->patientNrField]) && $row[$this->patientNrField])) {
            $messages[] = sprintf($this->_('Missing respondent number in %s field.'), $this->patientNrField);
                Severity: Minor
                Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Avoid excessively long class names like Gems_Model_Translator_RespondentAnswerTranslator. Keep class name length under 40.
                Open

                class Gems_Model_Translator_RespondentAnswerTranslator extends \Gems_Model_Translator_AnswerTranslatorAbstract
{
    /**
     *
     * @var \Zend_Db_Adapter_Abstract
                Severity: Minor
                Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php by phpmd

                LongClassName

                Since: 2.9

                Detects when classes or interfaces are declared with excessively long names.

                Example

                class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

                Source https://phpmd.org/rules/naming.html#longclassname

                Avoid variables with short names like $db. Configured minimum length is 3.
                Open

                    protected $db;
                Severity: Minor
                Found in classes/Gems/Model/Translator/RespondentAnswerTranslator.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                There are no issues that match your filters.

                Category
                Status