The class Gems_Snippets_Mail_MailFormSnippet has an overall complexity of 57 which is very high. The configured complexity threshold is 50. Open
class Gems_Snippets_Mail_MailFormSnippet extends \MUtil_Snippets_ModelSnippetAbstract
{
protected $afterSendRouteUrl;
/**
- Exclude checks
File MailFormSnippet.php
has 288 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package Gems
Function loadFormData
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
protected function loadFormData()
{
$presetTargetData = $this->mailer->getPresetTargetData();
if ($this->request->isPost()) {
$requestData = $this->request->getPost();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setAfterSendRoute
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
protected function setAfterSendRoute()
{
if ($this->routeAction && ($this->request->getActionName() !== $this->routeAction)) {
$this->afterSendRouteUrl = array('action' => $this->routeAction);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createFromSelect
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function createFromSelect($elementName='from', $label='')
{
$valid = array();
$invalid = array();
The class Gems_Snippets_Mail_MailFormSnippet has 19 fields. Consider redesigning Gems_Snippets_Mail_MailFormSnippet to keep the number of fields under 15. Open
class Gems_Snippets_Mail_MailFormSnippet extends \MUtil_Snippets_ModelSnippetAbstract
{
protected $afterSendRouteUrl;
/**
- Read upRead up
- Exclude checks
TooManyFields
Since: 0.1
Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.
Example
class Person {
protected $one;
private $two;
private $three;
[... many more fields ...]
}
Source https://phpmd.org/rules/codesize.html#toomanyfields
Method loadFormData
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function loadFormData()
{
$presetTargetData = $this->mailer->getPresetTargetData();
if ($this->request->isPost()) {
$requestData = $this->request->getPost();
Function createFromSelect
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function createFromSelect($elementName='from', $label='')
{
$valid = array();
$invalid = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createMultiOption
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function createMultiOption(array $requestData, $name, $email, $extra = null, $disabledTitle = false, $menuFind = false)
The method loadFormData() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
protected function loadFormData()
{
$presetTargetData = $this->mailer->getPresetTargetData();
if ($this->request->isPost()) {
$requestData = $this->request->getPost();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Gems_Snippets_Mail_MailFormSnippet has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13. Open
class Gems_Snippets_Mail_MailFormSnippet extends \MUtil_Snippets_ModelSnippetAbstract
{
protected $afterSendRouteUrl;
/**
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid unused parameters such as '$view'. Open
public function getHtmlOutput(\Zend_View_Abstract $view)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid variables with short names like $db. Configured minimum length is 3. Open
protected $db;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $i. Configured minimum length is 3. Open
$i = 1;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}