classes/Gems/Snippets/Respondent/Relation/YesNoDeleteSnippet.php
Function render has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
public function render(\Zend_View_Abstract $view)
{
// \MUtil_Echo::r(sprintf('Rendering snippet %s.', get_class($this)));
//
// TODO: Change snippet workings.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused parameters such as '$model'. Open
Open
protected function setShowTableFooter(\MUtil_Model_Bridge_VerticalTableBridge $bridge, \MUtil_Model_ModelAbstract $model)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
TODO found Open
Open
// TODO: Change snippet workings.- Exclude checks
Avoid excessively long class names like Gems_Snippets_Respondent_Relation_YesNoDeleteSnippet. Keep class name length under 40. Open
Open
class Gems_Snippets_Respondent_Relation_YesNoDeleteSnippet extends \Gems_Snippets_ModelItemYesNoDeleteSnippetGeneric
{
public function render(\Zend_View_Abstract $view)
{
// \MUtil_Echo::r(sprintf('Rendering snippet %s.', get_class($this)));- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}