GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Snippets/Survey/Display/BarChartSnippet.php

Summary

Maintainability
D
1 day
Test Coverage
F
0%

Function getChart has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function getChart()
    {
        $token = $this->token;
        $data = $this->data;
Severity: Minor
Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getChart has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getChart()
    {
        $token = $this->token;
        $data = $this->data;
Severity: Major
Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 3 hrs to fix

    Function doRulers has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function doRulers($chart)
        {
            $html = \MUtil_Html::create();
    
            if ($this->grid) {
    Severity: Minor
    Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doRulers has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doRulers($chart)
        {
            $html = \MUtil_Html::create();
    
            if ($this->grid) {
    Severity: Minor
    Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 1 hr to fix

      Method getHtmlOutput has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getHtmlOutput(\Zend_View_Abstract $view) {
              //$view->headLink()->prependStylesheet($view->serverUrl() . \GemsEscort::getInstance()->basepath->getBasePath() . '/gems/css/barchart.less', 'screen,print');
      
              $htmlDiv   = \MUtil_Html::create()->div(' ', array('class'=>'barchartcontainer'));
      
      Severity: Minor
      Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 1 hr to fix

        Function getHtmlOutput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getHtmlOutput(\Zend_View_Abstract $view) {
                //$view->headLink()->prependStylesheet($view->serverUrl() . \GemsEscort::getInstance()->basepath->getBasePath() . '/gems/css/barchart.less', 'screen,print');
        
                $htmlDiv   = \MUtil_Html::create()->div(' ', array('class'=>'barchartcontainer'));
        
        Severity: Minor
        Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method getChart() has an NPath complexity of 992. The configured NPath complexity threshold is 200.
        Open

            public function getChart()
            {
                $token = $this->token;
                $data = $this->data;
        

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method getChart() has 117 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

            public function getChart()
            {
                $token = $this->token;
                $data = $this->data;
        

        The method getChart() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
        Open

            public function getChart()
            {
                $token = $this->token;
                $data = $this->data;
        

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Avoid unused local variables such as '$range'.
        Open

                $range = $this->max - $this->min;

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
            public function doSomething()
            {
                $i = 5; // Unused
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid excessively long class names like Gems_Snippets_Survey_Display_BarChartSnippet. Keep class name length under 40.
        Open

        class Gems_Snippets_Survey_Display_BarChartSnippet extends \MUtil_Snippets_SnippetAbstract {
        
            /**
             * Switch to put the display of the cancel and print buttons.
             *

        LongClassName

        Since: 2.9

        Detects when classes or interfaces are declared with excessively long names.

        Example

        class ATooLongClassNameThatHintsAtADesignProblem {
        
        }
        
        interface ATooLongInterfaceNameThatHintsAtADesignProblem {
        
        }

        Source https://phpmd.org/rules/naming.html#longclassname

        The property $survey_code is not named in camelCase.
        Open

        class Gems_Snippets_Survey_Display_BarChartSnippet extends \MUtil_Snippets_SnippetAbstract {
        
            /**
             * Switch to put the display of the cancel and print buttons.
             *

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
            protected $property_name;
        }

        Source

        The property $question_code is not named in camelCase.
        Open

        class Gems_Snippets_Survey_Display_BarChartSnippet extends \MUtil_Snippets_SnippetAbstract {
        
            /**
             * Switch to put the display of the cancel and print buttons.
             *

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
            protected $property_name;
        }

        Source

        The property $question_text is not named in camelCase.
        Open

        class Gems_Snippets_Survey_Display_BarChartSnippet extends \MUtil_Snippets_SnippetAbstract {
        
            /**
             * Switch to put the display of the cancel and print buttons.
             *

        CamelCasePropertyName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name attributes.

        Example

        class ClassName {
            protected $property_name;
        }

        Source

        There are no issues that match your filters.

        Category
        Status