GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Snippets/Token/PlanSearchSnippet.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method getAutoSearchElements has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getAutoSearchElements(array $data)
    {
        $elements = parent::getAutoSearchElements($data);

        if ($elements) {
Severity: Major
Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php - About 2 hrs to fix

    File PlanSearchSnippet.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     *
     * @package    Gems
    Severity: Minor
    Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php - About 2 hrs to fix

      Method addFillerIdSelect has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addFillerIdSelect(array &$elements, $data, $elementId = 'filler')
          {
              if (isset($data['gto_id_track']) && !empty($data['gto_id_track'])) {
                  $trackId = (int) $data['gto_id_track'];
              } else {
      Severity: Minor
      Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php - About 1 hr to fix

        Method addFillerSelect has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function addFillerSelect(array &$elements, $data, $elementId = 'filler')
            {
                if (isset($data['gto_id_track']) && !empty($data['gto_id_track'])) {
                    $trackId = (int) $data['gto_id_track'];
                } else {
        Severity: Minor
        Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php - About 1 hr to fix

          Method getAllGroups has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getAllGroups($allowedOrgs, array $data)
              {
                  if ($allowedOrgs) {
                      $orgIn = "gto_id_organization IN (" . implode(',', array_keys($allowedOrgs)) . ")";
                      $orgWhere = "(INSTR(gtr_organizations, '|" .
          Severity: Minor
          Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php - About 1 hr to fix

            Avoid unused parameters such as '$data'.
            Open

                protected function getAllCreators(array $allowedOrgs, array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$data'.
            Open

                protected function getAllTrackTypes($allowedOrgs, array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$data'.
            Open

                protected function getAllGroups($allowedOrgs, array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$data'.
            Open

                protected function getAllTrackRounds($allowedOrgs, array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$data'.
            Open

                protected function getAllSurveys($allowedOrgs, array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Avoid unused parameters such as '$data'.
            Open

                protected function getOrganizationList(array $data)

            UnusedFormalParameter

            Since: 0.2

            Avoid passing parameters to methods or constructors and then not using those parameters.

            Example

            class Foo
            {
                private function bar($howdy)
                {
                    // $howdy is not used
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                protected function getAllGroups($allowedOrgs, array $data)
                {
                    if ($allowedOrgs) {
                        $orgIn = "gto_id_organization IN (" . implode(',', array_keys($allowedOrgs)) . ")";
                        $orgWhere = "(INSTR(gtr_organizations, '|" .
            Severity: Major
            Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php and 2 other locations - About 1 hr to fix
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 312..346
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 365..395

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                protected function getAllTrackRounds($allowedOrgs, array $data)
                {
                    if ($allowedOrgs) {
                        $orgIn = "gto_id_organization IN (" . implode(',', array_keys($allowedOrgs)) . ")";
                        $orgWhere = "(INSTR(gtr_organizations, '|" .
            Severity: Major
            Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php and 2 other locations - About 1 hr to fix
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 272..304
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 365..395

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                protected function getAllSurveys($allowedOrgs, array $data)
                {
                    if ($allowedOrgs) {
                        $orgIn = "gto_id_organization IN (" . implode(',', array_keys($allowedOrgs)) . ")";
                        $orgWhere = "(INSTR(gtr_organizations, '|" .
            Severity: Major
            Found in classes/Gems/Snippets/Token/PlanSearchSnippet.php and 2 other locations - About 1 hr to fix
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 272..304
            classes/Gems/Snippets/Token/PlanSearchSnippet.php on lines 312..346

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status