File UpgradeCompatibilitySnippet.php
has 601 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package Gems
Method _checkCodingChanged
has 119 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$phpObjects = array(
'ArrayAccess',
'ArrayIterator',
Function _checkCodingChanged
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$phpObjects = array(
'ArrayAccess',
'ArrayIterator',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function addProjectIniReport
has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
protected function addProjectIniReport()
{
$h3 = $this->html->h3();
$issues = false;
if (! $this->project->offsetExists('headers')) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class UpgradeCompatibilitySnippet has an overall complexity of 97 which is very high. The configured complexity threshold is 50. Open
class UpgradeCompatibilitySnippet extends \MUtil_Snippets_SnippetAbstract
{
/**
* When true there is a namespace error in the application code
*
- Exclude checks
Method _checkControllersChanged
has 83 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _checkControllersChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$fileName = $fileinfo->getFilename();
switch ($fileName) {
case 'MailJobController.php':
Method _checkTablesChanged
has 80 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _checkTablesChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$obsoleteFields = array(
'gr2o_email' => 'grs_email',
'gr2t_track_info' => 'calc_track_info',
Method addProjectIniReport
has 62 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function addProjectIniReport()
{
$h3 = $this->html->h3();
$issues = false;
if (! $this->project->offsetExists('headers')) {
Function _checkTablesChanged
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkTablesChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$obsoleteFields = array(
'gr2o_email' => 'grs_email',
'gr2t_track_info' => 'calc_track_info',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _checkControllersChanged
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkControllersChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$fileName = $fileinfo->getFilename();
switch ($fileName) {
case 'MailJobController.php':
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _checkSnippetsChanged
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkSnippetsChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$filePathName = $fileinfo->getPathname();
foreach ($this->movedSnippets as $oldSnippet => $newSnippet) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addEscortReport
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function addEscortReport()
{
$this->html->h3('Project and escort class report');
$escortClass = get_class($this->escort);
Function _checkVariablesChanged
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkVariablesChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$filePathName = $fileinfo->getPathname();
foreach ($this->variablesChanged as $pathPart => $replacements) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _checkDepreciations
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function _checkDepreciations(\SplFileInfo $fileinfo, $content, array &$messages)
{
$matches = [];
if (preg_match('/\\s@deprecated\\s+([^\\n]+)/', $content, $matches)) {
$gemsVersion = $this->loader->getVersions()->getGemsVersion();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addFileReport
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function addFileReport(\SplFileInfo $fileinfo)
{
// $extension = strtolower($fileinfo->getExtension());
$extension = strtolower(pathinfo($fileinfo, PATHINFO_EXTENSION));
if (('php' !== $extension) && ('phtml' !== $extension)) {
Function addFileReport
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function addFileReport(\SplFileInfo $fileinfo)
{
// $extension = strtolower($fileinfo->getExtension());
$extension = strtolower(pathinfo($fileinfo, PATHINFO_EXTENSION));
if (('php' !== $extension) && ('phtml' !== $extension)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method _checkCodingChanged() has 130 lines of code. Current threshold is set to 100. Avoid really long methods. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$phpObjects = array(
'ArrayAccess',
'ArrayIterator',
- Exclude checks
The method _checkCodingChanged() has an NPath complexity of 720. The configured NPath complexity threshold is 200. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$phpObjects = array(
'ArrayAccess',
'ArrayIterator',
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method addProjectIniReport() has an NPath complexity of 1280. The configured NPath complexity threshold is 200. Open
protected function addProjectIniReport()
{
$h3 = $this->html->h3();
$issues = false;
if (! $this->project->offsetExists('headers')) {
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method _checkControllersChanged() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10. Open
protected function _checkControllersChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$fileName = $fileinfo->getFilename();
switch ($fileName) {
case 'MailJobController.php':
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method addProjectIniReport() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
protected function addProjectIniReport()
{
$h3 = $this->html->h3();
$issues = false;
if (! $this->project->offsetExists('headers')) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method _checkCodingChanged() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
{
$phpObjects = array(
'ArrayAccess',
'ArrayIterator',
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid unused parameters such as '$fileinfo'. Open
protected function _checkDepreciations(\SplFileInfo $fileinfo, $content, array &$messages)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$view'. Open
public function getHtmlOutput(\Zend_View_Abstract $view)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$dir'. Open
foreach ($this->escort->getLoaderDirs() as $prefix => $dir) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused parameters such as '$fileinfo'. Open
protected function _checkCodingChanged(\SplFileInfo $fileinfo, $content, array &$messages)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$content'. Open
protected function _checkSnippetsChanged(\SplFileInfo $fileinfo, $content, array &$messages)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$fileinfo'. Open
protected function _checkTablesChanged(\SplFileInfo $fileinfo, $content, array &$messages)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid variables with short names like $r. Configured minimum length is 3. Open
preg_match_all("/(\w+-src(-\w+)?) ([^;]+);/", $headers['Content-Security-Policy'], $r);
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $h3. Configured minimum length is 3. Open
$h3 = $this->html->h3();
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $p. Configured minimum length is 3. Open
$p = $sCode->pInfo('To use this script you have to install ');
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}