Function execute
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
{
$this->currentUser->disableMask();
$sql = $this->db->select()->from('gems__comm_jobs')
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method execute
has 120 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
{
$this->currentUser->disableMask();
$sql = $this->db->select()->from('gems__comm_jobs')
Method getToEmail
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getToEmail(array $job, $sendByMail, \Gems_Mail_TokenMailer $mailer, \Gems_Tracker_Token $token, $canBeMailed)
{
$email = null;
switch ($job['gcj_target']) {
Function getToEmail
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function getToEmail(array $job, $sendByMail, \Gems_Mail_TokenMailer $mailer, \Gems_Tracker_Token $token, $canBeMailed)
{
$email = null;
switch ($job['gcj_target']) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method execute
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
Method getToEmail
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function getToEmail(array $job, $sendByMail, \Gems_Mail_TokenMailer $mailer, \Gems_Tracker_Token $token, $canBeMailed)
The method execute() has an NPath complexity of 1064. The configured NPath complexity threshold is 200. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
{
$this->currentUser->disableMask();
$sql = $this->db->select()->from('gems__comm_jobs')
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method execute() has 164 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
{
$this->currentUser->disableMask();
$sql = $this->db->select()->from('gems__comm_jobs')
- Exclude checks
The method getToEmail() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
protected function getToEmail(array $job, $sendByMail, \Gems_Mail_TokenMailer $mailer, \Gems_Tracker_Token $token, $canBeMailed)
{
$email = null;
switch ($job['gcj_target']) {
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method execute() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10. Open
public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
{
$this->currentUser->disableMask();
$sql = $this->db->select()->from('gems__comm_jobs')
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid unused parameters such as '$sendByMail'. Open
protected function getFromName(array $job, $sendByMail, \Gems_Mail_TokenMailer $mailer)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid variables with short names like $db. Configured minimum length is 3. Open
protected $db;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}