GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Tracker/Field/AppointmentField.php

Summary

Maintainability
D
1 day
Test Coverage
D
66%

Function calculateFieldValue has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
    {
        if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
            $agenda = $this->loader->getAgenda();

Severity: Minor
Found in classes/Gems/Tracker/Field/AppointmentField.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculateFieldValue has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
    {
        if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
            $agenda = $this->loader->getAgenda();

Severity: Major
Found in classes/Gems/Tracker/Field/AppointmentField.php - About 3 hrs to fix

    Function showAppointment has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function showAppointment($value)
        {
            if (! $value) {
                return $this->_('Unknown');
            }
    Severity: Minor
    Found in classes/Gems/Tracker/Field/AppointmentField.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method showAppointment has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function showAppointment($value)
        {
            if (! $value) {
                return $this->_('Unknown');
            }
    Severity: Minor
    Found in classes/Gems/Tracker/Field/AppointmentField.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              switch ($this->_fieldDefinition['gtf_uniqueness']) {
                                  case 1: // Track instances may link only once to an appointment
                                      $select->uniqueInTrackInstance(
                                              self::$_lastActiveAppointmentIds[$this->_lastActiveKey]
                                              );
      Severity: Major
      Found in classes/Gems/Tracker/Field/AppointmentField.php - About 45 mins to fix

        The method calculateFieldValue() has an NPath complexity of 1990. The configured NPath complexity threshold is 200.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method calculateFieldValue() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Avoid unused parameters such as '$fieldData'.
        Open

            public function calculateFieldInfo($currentValue, array $fieldData)

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
        {
            private function bar($howdy)
            {
                // $howdy is not used
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused parameters such as '$fieldData'.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
        {
            private function bar($howdy)
            {
                // $howdy is not used
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused parameters such as '$new'.
        Open

            public function getDataModelDependyChanges(array $context, $new)

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
        {
            private function bar($howdy)
            {
                // $howdy is not used
            }
        }

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid excessively long variable names like $_lastActiveAppointmentIds. Keep variable name length under 20.
        Open

            protected static $_lastActiveAppointmentIds = array();

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
            protected $reallyLongIntName = -3; // VIOLATION - Field
            public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                $otherReallyLongName = -5; // VIOLATION - Local
                for ($interestingIntIndex = 0; // VIOLATION - For
                     $interestingIntIndex < 10;
                     $interestingIntIndex++ ) {
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $appointmentTimeFormat. Keep variable name length under 20.
        Open

            protected $appointmentTimeFormat = 'dd MMM yyyy HH:mm';

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
            protected $reallyLongIntName = -3; // VIOLATION - Field
            public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                $otherReallyLongName = -5; // VIOLATION - Local
                for ($interestingIntIndex = 0; // VIOLATION - For
                     $interestingIntIndex < 10;
                     $interestingIntIndex++ ) {
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $_lastActiveAppointment. Keep variable name length under 20.
        Open

            protected static $_lastActiveAppointment = array();

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
            protected $reallyLongIntName = -3; // VIOLATION - Field
            public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                $otherReallyLongName = -5; // VIOLATION - Local
                for ($interestingIntIndex = 0; // VIOLATION - For
                     $interestingIntIndex < 10;
                     $interestingIntIndex++ ) {
                }
            }
        }

        Source https://phpmd.org/rules/naming.html#longvariable

        The variable $_lastActiveAppointmentIds is not named in camelCase.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointmentIds is not named in camelCase.
        Open

            public function calculationStart(array $trackData)
            {
                if (isset($trackData['gr2t_id_respondent_track'])) {
                    $this->_lastActiveKey = $trackData['gr2t_id_respondent_track'];
                } elseif (isset($trackData['gr2t_id_user'], $trackData['gr2t_id_organization'])) {

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointment is not named in camelCase.
        Open

            public function calculationStart(array $trackData)
            {
                if (isset($trackData['gr2t_id_respondent_track'])) {
                    $this->_lastActiveKey = $trackData['gr2t_id_respondent_track'];
                } elseif (isset($trackData['gr2t_id_user'], $trackData['gr2t_id_organization'])) {

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointmentIds is not named in camelCase.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointmentIds is not named in camelCase.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointment is not named in camelCase.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        The variable $_lastActiveAppointment is not named in camelCase.
        Open

            public function calculateFieldValue($currentValue, array $fieldData, array $trackData)
            {
                if ($currentValue || isset($this->_fieldDefinition['gtf_filter_id'])) {
                    $agenda = $this->loader->getAgenda();
        
        

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
            public function doSomething() {
                $data_module = new DataModule();
            }
        }

        Source

        There are no issues that match your filters.

        Category
        Status