Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/Tracker/Model/RespondentTrackModel.php

Summary

Maintainability
B
6 hrs
Test Coverage
A
93%

Function loadNew has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadNew($count = null, array $filter = null)
    {
        $values = array();

        // Get the defaults
Severity: Minor
Found in classes/Gems/Tracker/Model/RespondentTrackModel.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadNew has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadNew($count = null, array $filter = null)
    {
        $values = array();

        // Get the defaults
Severity: Minor
Found in classes/Gems/Tracker/Model/RespondentTrackModel.php - About 1 hr to fix

    Method applyDetailSettings has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function applyDetailSettings(\Gems_Tracker_Engine_TrackEngineInterface $trackEngine, $edit = false)
    {
        $this->resetOrder();

        $translated = $this->util->getTranslated();
    Severity: Minor
    Found in classes/Gems/Tracker/Model/RespondentTrackModel.php - About 1 hr to fix

      Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct($name = 'surveys')
    {
        parent::__construct($name, 'gems__respondent2track', 'gr2t', true);
        $this->addTable('gems__respondents',     array('gr2t_id_user' => 'grs_id_user'), 'grs', false);
        $this->addTable(
      Severity: Minor
      Found in classes/Gems/Tracker/Model/RespondentTrackModel.php - About 1 hr to fix

        Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function save(array $newValues, array $filter = null)
    {
        $keys = $this->getKeys();

        // This is the only key to save on, no matter
        Severity: Minor
        Found in classes/Gems/Tracker/Model/RespondentTrackModel.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

                // TODO: altkeys implementatie
        Severity: Minor
        Found in classes/Gems/Tracker/Model/RespondentTrackModel.php by fixme

        Avoid excessively long variable names like $includeNumericFilters. Keep variable name length under 20.
        Open

            public function applyParameters(array $parameters, $includeNumericFilters = false)
        Severity: Minor
        Found in classes/Gems/Tracker/Model/RespondentTrackModel.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid variables with short names like $db. Configured minimum length is 3.
        Open

                    $db = $this->getAdapter();
        Severity: Minor
        Found in classes/Gems/Tracker/Model/RespondentTrackModel.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $id. Configured minimum length is 3.
        Open

                        $id = $parameters[\Gems_Model::RESPONDENT_TRACK];
        Severity: Minor
        Found in classes/Gems/Tracker/Model/RespondentTrackModel.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        There are no issues that match your filters.

        Category
        Status