GemsTracker/gemstracker-library

View on GitHub
classes/Gems/Tracker/Snippets/EditTrackSnippetAbstract.php

Summary

Maintainability
B
6 hrs
Test Coverage
C
73%

Function hasHtmlOutput has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function hasHtmlOutput()
    {
        if ($this->respondent instanceof \Gems_Tracker_Respondent) {
            if (! $this->patientId) {
                $this->patientId = $this->respondent->getPatientNumber();
Severity: Minor
Found in classes/Gems/Tracker/Snippets/EditTrackSnippetAbstract.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hasHtmlOutput has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function hasHtmlOutput()
    {
        if ($this->respondent instanceof \Gems_Tracker_Respondent) {
            if (! $this->patientId) {
                $this->patientId = $this->respondent->getPatientNumber();
Severity: Minor
Found in classes/Gems/Tracker/Snippets/EditTrackSnippetAbstract.php - About 1 hr to fix

    Function loadFormData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function loadFormData()
        {
            $model = $this->getModel();
    
            // When creating and not posting nor having $this->formData set already
    Severity: Minor
    Found in classes/Gems/Tracker/Snippets/EditTrackSnippetAbstract.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method hasHtmlOutput() has an NPath complexity of 4230. The configured NPath complexity threshold is 200.
    Open

        public function hasHtmlOutput()
        {
            if ($this->respondent instanceof \Gems_Tracker_Respondent) {
                if (! $this->patientId) {
                    $this->patientId = $this->respondent->getPatientNumber();

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method hasHtmlOutput() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
    Open

        public function hasHtmlOutput()
        {
            if ($this->respondent instanceof \Gems_Tracker_Respondent) {
                if (! $this->patientId) {
                    $this->patientId = $this->respondent->getPatientNumber();

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid excessively long class names like Gems_Tracker_Snippets_EditTrackSnippetAbstract. Keep class name length under 40.
    Open

    class Gems_Tracker_Snippets_EditTrackSnippetAbstract extends \Gems_Snippets_ModelFormSnippetAbstract
    {
        /**
         *
         * @var \Gems_User_User

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {
    
    }
    
    interface ATooLongInterfaceNameThatHintsAtADesignProblem {
    
    }

    Source https://phpmd.org/rules/naming.html#longclassname

    There are no issues that match your filters.

    Category
    Status