File LimeSurvey1m9FieldMap.php
has 702 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package Gems
Function applyToModel
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
public function applyToModel(\MUtil_Model_ModelAbstract $model)
{
$map = $this->_getMap();
$oldfld = null;
$parent = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _getMap
has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring. Open
protected function _getMap()
{
$cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
$this->_fieldMap = $this->cache->load($cacheId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _getMap
has 158 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _getMap()
{
$cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
$this->_fieldMap = $this->cache->load($cacheId);
Method applyToModel
has 84 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function applyToModel(\MUtil_Model_ModelAbstract $model)
{
$map = $this->_getMap();
$oldfld = null;
$parent = null;
The class Gems_Tracker_Source_LimeSurvey1m9FieldMap has an overall complexity of 197 which is very high. The configured complexity threshold is 50. Open
class Gems_Tracker_Source_LimeSurvey1m9FieldMap
{
const ANSWERS_TABLE = 'answers';
const ATTRIBUTES_TABLE = 'question_attributes';
const CONDITIONS_TABLE = 'conditions';
- Exclude checks
Function getQuestionInformation
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
public function getQuestionInformation()
{
$map = $this->_getMap();
$oldfld = null;
$result = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Gems_Tracker_Source_LimeSurvey1m9FieldMap
has 26 functions (exceeds 20 allowed). Consider refactoring. Open
class Gems_Tracker_Source_LimeSurvey1m9FieldMap
{
const ANSWERS_TABLE = 'answers';
const ATTRIBUTES_TABLE = 'question_attributes';
const CONDITIONS_TABLE = 'conditions';
Function getQuestionList
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
public function getQuestionList($forType = false)
{
$map = $this->_getMap();
$results = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _getPossibleAnswers
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function _getPossibleAnswers($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$code = $field['code'];
Function _getPossibleAnswers
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
private function _getPossibleAnswers($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$code = $field['code'];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getQuestionInformation
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getQuestionInformation()
{
$map = $this->_getMap();
$oldfld = null;
$result = array();
Method _getType
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _getType($field)
{
switch ($field['type']) {
case ':':
//Get the labels that could apply!
Function _getType
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
protected function _getType($field)
{
switch ($field['type']) {
case ':':
//Get the labels that could apply!
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _getHardAnswers
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
private function _getHardAnswers($qid, $scaleId)
{
if (! is_array($this->_hardAnswers)) {
$qaTable = $this->_getAnswersTableName();
$qTable = $this->_getQuestionsTableName();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getDateFormats
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
protected function getDateFormats($fieldname, $type)
{
if ($dataType = $this->getFieldTableDataType($fieldname)) {
if ($dataType == 'datetime' || $dataType == 'timestamp') {
$tmpres['storageFormat'] = 'yyyy-MM-dd HH:mm:ss';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _getFixedAnswers
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function _getFixedAnswers($type)
{
switch ($type) {
case ':':
$answers[1] = $this->translate->_('Yes');
Method _getMultiOptions
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _getMultiOptions($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$qid = $field['qid'];
Method getQuestionList
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getQuestionList($forType = false)
{
$map = $this->_getMap();
$results = array();
Method __construct
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct($sourceSurveyId, $language, \Zend_Db_Adapter_Abstract $lsDb, \Zend_Translate $translate, $tablePrefix, \Zend_Cache_Core $cache, $sourceId)
Function _getQuestionAttribute
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function _getQuestionAttribute($qid, $attribute, $default = null)
{
if (! is_array($this->_attributes)) {
$this->_attributes = [];
$attributesTable = $this->_getQuestionAttributesTableName();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if ($row['type'] === 'P' || $row['type'] === 'M') {
$row['type'] = 'S';
}
Avoid deeply nested control flow statements. Open
if ($rows[$i]['type'] == 'P') {
$row['sgq'] .= 'comment';
$row['code'] .= 'comment';
$row['sq_title'] .= 'comment';
$row['sq_question'] = ($rows[$i]['type'] === 'O') ? $this->translate->_('Comment') : $row['sq_question'] . $this->translate->_(' (comment)');
Function _getTitlesMap
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function _getTitlesMap() {
if (! is_array($this->_titlesMap)) {
$map = $this->_getMap();
$result = array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _getFixedAnswers
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
private function _getFixedAnswers($type)
{
switch ($type) {
case ':':
$answers[1] = $this->translate->_('Yes');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return \MUtil_Model::TYPE_DATE;
Avoid too many return
statements within this method. Open
return \MUtil_Model::TYPE_STRING;
Avoid too many return
statements within this method. Open
return \MUtil_Model::TYPE_DATETIME;
Avoid too many return
statements within this method. Open
return \MUtil_Model::TYPE_DATETIME;
Avoid too many return
statements within this method. Open
return \MUtil_Model::TYPE_NOVALUE;
The method _getMap() has an NPath complexity of 203. The configured NPath complexity threshold is 200. Open
protected function _getMap()
{
$cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
$this->_fieldMap = $this->cache->load($cacheId);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getQuestionInformation() has an NPath complexity of 481. The configured NPath complexity threshold is 200. Open
public function getQuestionInformation()
{
$map = $this->_getMap();
$oldfld = null;
$result = array();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method _getMap() has 187 lines of code. Current threshold is set to 100. Avoid really long methods. Open
protected function _getMap()
{
$cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
$this->_fieldMap = $this->cache->load($cacheId);
- Exclude checks
The method applyToModel() has an NPath complexity of 1166401. The configured NPath complexity threshold is 200. Open
public function applyToModel(\MUtil_Model_ModelAbstract $model)
{
$map = $this->_getMap();
$oldfld = null;
$parent = null;
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method applyToModel() has 109 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function applyToModel(\MUtil_Model_ModelAbstract $model)
{
$map = $this->_getMap();
$oldfld = null;
$parent = null;
- Exclude checks
The class Gems_Tracker_Source_LimeSurvey1m9FieldMap has 1035 lines of code. Current threshold is 1000. Avoid really long classes. Open
class Gems_Tracker_Source_LimeSurvey1m9FieldMap
{
const ANSWERS_TABLE = 'answers';
const ATTRIBUTES_TABLE = 'question_attributes';
const CONDITIONS_TABLE = 'conditions';
- Exclude checks
The method _getMultiOptions() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10. Open
protected function _getMultiOptions($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$qid = $field['qid'];
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method _getPossibleAnswers() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10. Open
private function _getPossibleAnswers($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$code = $field['code'];
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method _getType() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
protected function _getType($field)
{
switch ($field['type']) {
case ':':
//Get the labels that could apply!
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getDateFormats() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
protected function getDateFormats($fieldname, $type)
{
if ($dataType = $this->getFieldTableDataType($fieldname)) {
if ($dataType == 'datetime' || $dataType == 'timestamp') {
$tmpres['storageFormat'] = 'yyyy-MM-dd HH:mm:ss';
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getQuestionList() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
public function getQuestionList($forType = false)
{
$map = $this->_getMap();
$results = array();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method applyToModel() has a Cyclomatic Complexity of 29. The configured cyclomatic complexity threshold is 10. Open
public function applyToModel(\MUtil_Model_ModelAbstract $model)
{
$map = $this->_getMap();
$oldfld = null;
$parent = null;
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getQuestionInformation() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function getQuestionInformation()
{
$map = $this->_getMap();
$oldfld = null;
$result = array();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method _getMap() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10. Open
protected function _getMap()
{
$cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
$this->_fieldMap = $this->cache->load($cacheId);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Identical blocks of code found in 2 locations. Consider refactoring. Open
switch ($row['type']) {
case '1': //Dual scale
//Check scale header in attributes table
$row1 = $row;
$row1['sgq'] .= $row['sq_title'] . '#0';
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 1462.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected function _getQuestionAttribute($qid, $attribute, $default = null)
{
if (! is_array($this->_attributes)) {
$this->_attributes = [];
$attributesTable = $this->_getQuestionAttributesTableName();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 242.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
protected function _getMultiOptions($field)
{
$scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
$qid = $field['qid'];
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 198.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long class names like Gems_Tracker_Source_LimeSurvey1m9FieldMap. Keep class name length under 40. Open
class Gems_Tracker_Source_LimeSurvey1m9FieldMap
{
const ANSWERS_TABLE = 'answers';
const ATTRIBUTES_TABLE = 'question_attributes';
const CONDITIONS_TABLE = 'conditions';
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}