Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star
classes/Gems/User/Form/ChangePasswordForm.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

The class Gems_User_Form_ChangePasswordForm has an overall complexity of 59 which is very high. The configured complexity threshold is 50.
Open

class Gems_User_Form_ChangePasswordForm extends \Gems_Form_AutoLoadFormAbstract
        implements \Gems_User_Validate_GetUserInterface
{
    /**
     * The field name for the new password element.
Severity: Minor
Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

Gems_User_Form_ChangePasswordForm has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class Gems_User_Form_ChangePasswordForm extends \Gems_Form_AutoLoadFormAbstract
        implements \Gems_User_Validate_GetUserInterface
{
    /**
     * The field name for the new password element.
Severity: Minor
Found in classes/Gems/User/Form/ChangePasswordForm.php - About 3 hrs to fix

    File ChangePasswordForm.php has 286 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 *
 * @package    Gems
    Severity: Minor
    Found in classes/Gems/User/Form/ChangePasswordForm.php - About 2 hrs to fix

      Function isValid has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function isValid($data, $disableTranslateValidators = null)
    {
        $valid = parent::isValid($data, $disableTranslateValidators);

        if ($valid === false && $this->forceRules === false) {
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getReportRulesElement has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getReportRulesElement()
    {
        $element = $this->getElement($this->_reportRulesFieldName);

        if (! $element) {
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addCheckFields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function addCheckFields()
    {
        $check = 1;
        foreach ($this->checkFields as $label => &$value) {
            if ($value instanceof \Zend_Form_Element) {
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class Gems_User_Form_ChangePasswordForm has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
      Open

      class Gems_User_Form_ChangePasswordForm extends \Gems_Form_AutoLoadFormAbstract
        implements \Gems_User_Validate_GetUserInterface
{
    /**
     * The field name for the new password element.
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid excessively long variable names like $_newPasswordFieldName. Keep variable name length under 20.
      Open

          protected $_newPasswordFieldName = 'new_password';
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $_oldPasswordFieldName. Keep variable name length under 20.
      Open

          protected $_oldPasswordFieldName = 'old_password';
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $_reportNoEnforcementFieldName. Keep variable name length under 20.
      Open

          protected $_reportNoEnforcementFieldName = 'report_no_enforcement';
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $disableTranslateValidators. Keep variable name length under 20.
      Open

          public function isValid($data, $disableTranslateValidators = null)
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $_reportRulesFieldName. Keep variable name length under 20.
      Open

          protected $_reportRulesFieldName = 'report_rules';
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $_repeatPasswordFieldName. Keep variable name length under 20.
      Open

          protected $_repeatPasswordFieldName = 'repeat_password';
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid using short method names like Gems_User_Form_ChangePasswordForm::_(). The configured minimum method name length is 3.
      Open

          public function _($text, $locale = null)
    {
        return $this->translateAdapter->_($text, $locale);
    }
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      The 'getAskCheck()' method which returns a boolean should be named 'is...()' or 'has...()'
      Open

          public function getAskCheck()
    {
        return $this->askCheck;
    }
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      BooleanGetMethodName

      Since: 0.2

      Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

      Example

      class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

      Source https://phpmd.org/rules/naming.html#booleangetmethodname

      The 'getAskOld()' method which returns a boolean should be named 'is...()' or 'has...()'
      Open

          public function getAskOld()
    {
        if (null === $this->askOld) {
            // By default only ask for the old password if the user just entered
            // it but is required to change it.
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      BooleanGetMethodName

      Since: 0.2

      Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

      Example

      class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

      Source https://phpmd.org/rules/naming.html#booleangetmethodname

      The method _ is not named in camelCase.
      Open

          public function _($text, $locale = null)
    {
        return $this->translateAdapter->_($text, $locale);
    }
      Severity: Minor
      Found in classes/Gems/User/Form/ChangePasswordForm.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status