File CommJobsUtil.php has 307 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package GemsThe class CommJobsUtil has an overall complexity of 63 which is very high. The configured complexity threshold is 50. Open
class CommJobsUtil extends UtilAbstract
{
/**
* @var \Gems_Loader
*/- Exclude checks
Method getAllGroups has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getAllGroups($trackId = null, $target = -1)
{
if(is_null($trackId)) {
$trackId = -1;
}Function getAllGroups has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function getAllGroups($trackId = null, $target = -1)
{
if(is_null($trackId)) {
$trackId = -1;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getJobFilter has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getJobFilter($job, $respondentId = null, $organizationId = null, $forceSent = false)
{
// Set up filter
$filter = array(
'gtr_active' => 1,Method _addToFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _addToFilter(array &$filter, $target, $toMethod, $fallbackMethod)
{
switch ($target) {
case 3:
// StaffFunction getJobFilter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function getJobFilter($job, $respondentId = null, $organizationId = null, $forceSent = false)
{
// Set up filter
$filter = array(
'gtr_active' => 1,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _addToFilter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function _addToFilter(array &$filter, $target, $toMethod, $fallbackMethod)
{
switch ($target) {
case 3:
// Staff- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _addModeFilter has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function _addModeFilter(array &$filter, $mode, $daysBetween, $maxReminders, $forceSent = false)Function _addModeFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function _addModeFilter(array &$filter, $mode, $daysBetween, $maxReminders, $forceSent = false)
{
switch ($mode) {
case 'B': // First mail before expiry
if (! $forceSent) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getAllGroups() has an NPath complexity of 210. The configured NPath complexity threshold is 200. Open
public function getAllGroups($trackId = null, $target = -1)
{
if(is_null($trackId)) {
$trackId = -1;
}- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getJobFilter() has an NPath complexity of 240. The configured NPath complexity threshold is 200. Open
public function getJobFilter($job, $respondentId = null, $organizationId = null, $forceSent = false)
{
// Set up filter
$filter = array(
'gtr_active' => 1,- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getJobFilter() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function getJobFilter($job, $respondentId = null, $organizationId = null, $forceSent = false)
{
// Set up filter
$filter = array(
'gtr_active' => 1,- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getAllGroups() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function getAllGroups($trackId = null, $target = -1)
{
if(is_null($trackId)) {
$trackId = -1;
}- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method _addToFilter() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
protected function _addToFilter(array &$filter, $target, $toMethod, $fallbackMethod)
{
switch ($target) {
case 3:
// Staff- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}